Provide a non-racey way to log into OpenShift cluster

Concurrent login attempts were being throttled so now we ensure that we
don't invoke this too many times at the same moment.

1_create_test_app_namespace.sh

@@ -6,7 +6,9 @@ set -euo pipefail
 announce "Creating Test App namespace."
 
 if [[ $PLATFORM == openshift ]]; then
-  oc login -u $OSHIFT_CLUSTER_ADMIN_USERNAME
+  if [[ "$(oc whoami)" != "$OSHIFT_CLUSTER_ADMIN_USERNAME" ]]; then
+    oc login -u $OSHIFT_CLUSTER_ADMIN_USERNAME
+  fi
 fi
 
 set_namespace default

ci/platform_login

@@ -6,6 +6,7 @@ IFS=$'\n\t'
 function main() {
   # Log in to platform
   if [[ "$PLATFORM" = "kubernetes" ]]; then
+
     gcloud auth activate-service-account \
       --key-file $GCLOUD_SERVICE_KEY
     gcloud container clusters get-credentials \
@@ -15,14 +16,32 @@ function main() {
     docker login $DOCKER_REGISTRY_URL \
       -u oauth2accesstoken \
       -p "$(gcloud auth print-access-token)"
+
   elif [[ "$PLATFORM" = "openshift" ]]; then
+    echo "Logging into OpenShift..."
     oc login $OPENSHIFT_URL \
-      --username=$OPENSHIFT_USERNAME \
-      --password=$OPENSHIFT_PASSWORD \
-      --insecure-skip-tls-verify=true
-    docker login \
-      -u _ -p "$(oc whoami -t)" \
-      $DOCKER_REGISTRY_PATH
+            --username=$OPENSHIFT_USERNAME \
+            --password=$OPENSHIFT_PASSWORD \
+            --insecure-skip-tls-verify=true
+    echo "Logged into OpenShift"
+
+    echo "Logging into OpenShift Docker registry..."
+    retry_attempt=0
+    while ! docker login -u _ \
+                         -p "$(oc whoami -t)" \
+                         "$DOCKER_REGISTRY_PATH"; do
+      echo "Failed to login to $DOCKER_REGISTRY_PATH registry!"
+
+      retry_attempt=$(( $retry_attempt + 1 ))
+      if [[ $retry_attempt -gt 10 ]]; then
+        echo "ERROR: Was unable to login to OpenShift Docker registry after 10 attempts!"
+        exit 1
+      fi
+
+      sleep 2
+      echo "Retrying login..."
+    done
+    echo "Logged into OpenShift Docker registry"
   fi
 }
 

stop

@@ -3,10 +3,10 @@ set -euo pipefail
 
 . utils.sh
 
-set_namespace default
-
 if [[ $PLATFORM == openshift ]]; then
-  oc login -u $OSHIFT_CLUSTER_ADMIN_USERNAME
+  if [[ "$(oc whoami)" != "$OSHIFT_CLUSTER_ADMIN_USERNAME" ]]; then
+    oc login -u $OSHIFT_CLUSTER_ADMIN_USERNAME
+  fi
 fi
 
 if has_namespace $TEST_APP_NAMESPACE_NAME; then