Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding document analyzing CI/dockerfile #3940

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

apostasie
Copy link
Contributor

Title says all.

Sharing audit notes in a new document (we can also just slap this into an issue if it is better - I don't mind either way).

I am rewriting the Dockerfile now and will provide an updated audit to see if we have measurable improvements.

@apostasie apostasie force-pushed the analyze-dockerfile branch 2 times, most recently from 30881d4 to 91edb07 Compare February 26, 2025 23:39
@AkihiroSuda AkihiroSuda added this to the v2.0.4 milestone Feb 27, 2025
golang:${GO_VERSION}-bookworm => hack-build-base-debian
golang:${GO_VERSION}-alpine => hack-build-base
ubuntu:${UBUNTU_VERSION} => hack-base
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

( I once had a BuildKit PR to allow injecting a hook to update CAs, but it wasn't accepted 😞 moby/buildkit#4669 Still thinking about an alternative... )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah.
I always end-up doing some ridiculous monkeying for that kind of stuff (same for overloading apt config, netrc, etc). Deviating the base like here, or using secrets (secrets is neat, but forces you to have additional --mount for every RUN, which is highly unpractical).

I just think the Dockerfile as a front-end is not aging too well... things like Dagger or Earthly are kinda touching on this overall question (eg: of a better frontend for developer that leverages the buildkit DAG).

But then, Dockerfile is everywhere now, so... something "new" comes up with a price...

@AkihiroSuda AkihiroSuda added documentation Improvements or additions to documentation area/ci e.g., CI failure labels Feb 27, 2025
@apostasie
Copy link
Contributor Author

Let's keep this PR open a little while.

I'll add more measurements.

Marking draft.

@apostasie apostasie marked this pull request as draft February 27, 2025 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci e.g., CI failure documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants