Add support for remaining blkio settings #3950
Open
+557
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swagatbora90
force-pushed
the
blkio-options
branch
4 times, most recently
from
45a457d to
ef71f08
Compare
|
Test failures do not appear to be related to the specific change. Previous runs have already passed those checks. |
Signed-off-by: Swagat Bora <[email protected]>
swagatbora90
force-pushed
the
blkio-options
branch
from
ef71f08 to
39f89b3
Compare
djdongjin
reviewed
Mar 1, 2025
|
|
||
| func TestRunBlkioSettingCgroupV2(t *testing.T) { | ||
| t.Parallel() | ||
| testutil.DockerIncompatible(t) |
There was a problem hiding this comment.
why is this docker imcompatible?
| switch info.CgroupDriver { | ||
| case "none", "": | ||
| t.Skip("test requires cgroup driver") | ||
| } |
| } | ||
|
|
||
| for _, tt := range tests { | ||
| tt := tt // capture range variable |
There was a problem hiding this comment.
this is no longer needed after go 1.22 (or 1.21? not sure the exact version)
| @@ -414,7 +414,7 @@ IPFS flags: | |||
| - :nerd_face: `--ipfs-address`: Multiaddr of IPFS API (default uses `$IPFS_PATH` env variable if defined or local directory `~/.ipfs`) | |||
|
|
|||
| Unimplemented `docker run` flags: | |||
| `--blkio-weight-device`, `--cpu-rt-*`, `--device-*`, | |||
| `--cpu-rt-*`, `--device-cgroup-rule`, | |||
There was a problem hiding this comment.
can you also add these new flags to the this command doc?
Comment on lines
+153
to
+163
| BlkioWeight uint16 | ||
| // BlkioWeightDevice specifies the Block IO weight (relative device weight) | ||
| BlkioWeightDevice []string | ||
| // BlkioDeviceReadBps specifies the Block IO read rate limit(bytes per second) of a device | ||
| BlkioDeviceReadBps []string | ||
| // BlkioDeviceWriteBps specifies the Block IO write rate limit(bytes per second) of a device | ||
| BlkioDeviceWriteBps []string | ||
| // BlkioDeviceReadIOps specifies the Block IO read rate limit(IO per second) of a device | ||
| BlkioDeviceReadIOps []string | ||
| // BlkioDeviceWriteIOps specifies the Block IO read rate limit(IO per second) of a device | ||
| BlkioDeviceWriteIOps []string |
There was a problem hiding this comment.
Do we need to support these flags in other commands? If so I suggest we create a separate struct, e.g., Blkio.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nerdctl today has support for
--blkio-weight.This PR adds support for the remaining blkio options (as supported by docker).
Requires cgroup v2 and block device scheduler set to
bfqTesting