Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix alma targets #3965

Merged
merged 2 commits into from
Mar 4, 2025
Merged

CI: fix alma targets #3965

merged 2 commits into from
Mar 4, 2025

Conversation

apostasie
Copy link
Contributor

@apostasie apostasie commented Mar 3, 2025

  • [ ] ensure alma test are ran against the right version of containerd, ubuntu and rootlesskit inside the container testing matrix clarified separately
  • [ ] figure out why ipfs is currently broken PEBKAC
  • enable caching to speed-up the test-integration build
  • workaround the losetup weirdness with an extra mount for dev (that sounds vaguely familiar? some old centos / docker issue?) - presumably docker is faulty here against that (old) kernel - and there is a timing issue with how /dev is exposed, causing losetup to fail in a flaky way
  • split flaky/not flaky like for the others so we speed-up the run a bit
  • migrated TestRunDevice
  • non-flaky test suite is passing for both rootless and rootful
  • flaky test suite is passing for both rootless and rootful
  • [ ] TestStats has no reason to run on cgroups v1 (this is why it is hanging) - investigating to figure out why it would run unclear why it would have hung - might be a side-effect of mounting /dev that fixed it

Currently on top of trivial #3970 (< merge first).

@apostasie apostasie force-pushed the fix-alma branch 16 times, most recently from 7109146 to e97a698 Compare March 4, 2025 02:03
Signed-off-by: apostasie <[email protected]>
@apostasie apostasie changed the title [WIP] fix alma ci target CI: fix alma targets Mar 4, 2025
@apostasie
Copy link
Contributor Author

Ok, CI is green.

I am not 100% confident that I got all of it, but it is an improvement.

Runs are still quite slow (I guess the cost of the extra vm).

Suggesting we merge this and patch more if/when issues crop up.

@apostasie apostasie marked this pull request as ready for review March 4, 2025 04:45
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 59b9599 into containerd:main Mar 4, 2025
30 checks passed
@AkihiroSuda AkihiroSuda added this to the v2.0.4 milestone Mar 4, 2025
@AkihiroSuda AkihiroSuda added the area/ci e.g., CI failure label Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci e.g., CI failure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants