checkpoint/restore: allow passing network lock method to libcriu #1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danishprakash
commented
Dec 6, 2024
giuseppe
force-pushed
the
criu-network-lock
branch
from
4d10aef to
32fc80b
Compare
|
@danishprakash I've done some fixes to your patch and pushed a new version. Please let me know if this looks good to you and we can merge it. I am hurrying it because I am planning to cut a new release, and I'd like to have this patch |
danishprakash
commented
Dec 6, 2024
giuseppe
force-pushed
the
criu-network-lock
branch
from
32fc80b to
8257cd3
Compare
Netavark defaults to nftables but it seems that crun checkpoint doesn't allow setting firewall driver used for network locking and unlocking by criu. criu defaults to iptables and in situations where podman is installed without iptables, criu tries to use iptable utils and fails. Signed-off-by: Danish Prakash <[email protected]>
giuseppe
force-pushed
the
criu-network-lock
branch
from
8257cd3 to
c4f8c87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netavark defaults to nftables but it seems that crun checkpoint doesn't allow setting firewall driver used for network locking and unlocking by criu. criu defaults to iptables and in situations where podman is installed without iptables, criu tries to use iptable utils and fails.