Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use libtool to create libcrun_testing #1618

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

jpalus
Copy link
Contributor

@jpalus jpalus commented Dec 6, 2024

static library is supposed to be archive of object files. if libtool is not used libcrun_testing.a includes raw libocispec.la file instead of its object files.

@giuseppe
Copy link
Member

giuseppe commented Dec 8, 2024

please add a Signed-off-by: line to make the DCO test happy

static library is supposed to be archive of object files. if libtool is
not used libcrun_testing.a includes raw libocispec.la file instead of
its object files.

Signed-off-by: Jan Palus <[email protected]>
@jpalus jpalus force-pushed the libtool-libcrun_testing branch from d7beb9a to 6b2e619 Compare December 8, 2024 15:43
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppe giuseppe merged commit ae05b08 into containers:main Dec 9, 2024
53 checks passed
@jpalus jpalus deleted the libtool-libcrun_testing branch December 20, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants