Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase required PHP version to 8.1 #20

Merged
merged 10 commits into from
Mar 27, 2024
Merged

Increase required PHP version to 8.1 #20

merged 10 commits into from
Mar 27, 2024

Conversation

leofeyer
Copy link
Member

@ausi Would you prefer ^3.4 || ^4.0 || ^5.0 || ^6.0 || ^7.0 over ">=3.4" as version constraint for the Symfony packages? Can we maybe drop some old versions?

And can we make PHP 8.1 the minimum version?

@leofeyer leofeyer added the bug Something isn't working label Mar 26, 2024
@leofeyer leofeyer self-assigned this Mar 26, 2024
@leofeyer leofeyer requested a review from ausi March 26, 2024 17:40
@ausi ausi mentioned this pull request Mar 26, 2024
@ausi
Copy link
Member

ausi commented Mar 26, 2024

Would you prefer ^3.4 || ^4.0 || ^5.0 || ^6.0 || ^7.0 over ">=3.4" as version constraint for the Symfony packages? Can we maybe drop some old versions?

I changed it to ^5.4 || ^6.4 || ^7.0 in #22

@ausi
Copy link
Member

ausi commented Mar 26, 2024

And can we make PHP 8.1 the minimum version?

Yes, please ☺️

@ausi ausi changed the title Update the meta files and allow Symfony 6 and 7 Update the meta files Mar 27, 2024
@ausi
Copy link
Member

ausi commented Mar 27, 2024

I reverted the README in 6591878 as I use semantic line breaks there.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@ausi
Copy link
Member

ausi commented Mar 27, 2024

Rest looks good to me. Thank you! ❤️

@leofeyer
Copy link
Member Author

I reverted the README in 6591878 as I use semantic line breaks there.

I didn‘t know that. Sorry. 🙈

@leofeyer leofeyer changed the title Update the meta files Make PHP 8.1 the minimum version Mar 27, 2024
@leofeyer leofeyer requested a review from ausi March 27, 2024 08:55
@leofeyer leofeyer added enhancement New feature or request and removed bug Something isn't working labels Mar 27, 2024
composer.json Show resolved Hide resolved
Copy link
Member

@ausi ausi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! ❤️

@ausi ausi changed the title Make PHP 8.1 the minimum version Increase required PHP version to 8.1 Mar 27, 2024
@ausi ausi merged commit 1606370 into main Mar 27, 2024
7 checks passed
@ausi ausi deleted the feature/update branch March 27, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants