-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ALT-1508] fix: react-router import in gatsby spa to match the docs #930
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The gatsby app's package.json should probably install react-router-dom
(instead of react-router
) as a dependency to match this change as well
Sounds good, I did a mini quest and basically the summary is that react-router-dom is a super-set of react-router (basically has everything react-router has and more) |
61f0b32
to
615ae2d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👏
3c2ea0a
to
5ea7bcc
Compare
5ea7bcc
to
f6480bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it out locally and worked like a charm 🚀
Purpose
Update the react-router imports to match the Gatsby docs https://github.com/contentful/doc-app/pulls