Skip to content

Commit

Permalink
add comments and require environment at the top of the file
Browse files Browse the repository at this point in the history
  • Loading branch information
sestinj committed Jan 22, 2025
1 parent b729174 commit 105bb38
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions .github/workflows/pr_checks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ on:
- "gui/**"
- ".github/workflows/**"

# Tests requiring secrets need approval from maintainers
environment: ${{ github.event.pull_request.head.repo.fork && 'tests-requiring-secrets' || '' }}

jobs:
install-root:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -70,7 +73,6 @@ jobs:
core-checks:
needs: install-core
runs-on: ubuntu-latest
environment: ${{ github.event.pull_request.head.repo.fork && 'tests-requiring-secrets' || '' }}
steps:
- name: Print whether fork
run: |
Expand Down Expand Up @@ -399,8 +401,7 @@ jobs:
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version-file: ".nvmrc"
with: node-version-k

- uses: actions/cache@v4
id: vscode-node-modules-cache
Expand Down Expand Up @@ -585,6 +586,9 @@ jobs:
path: |
${{ github.workspace }}/extensions/intellij/build/reports
# GitHub does not have a way of requiring that all checks pass (you must manually select each job)
# This action at least lets us manage the list of required tests via source control
# so that creators of new jobs can add them to this list
require-all-checks-to-pass:
if: always()
runs-on: ubuntu-latest
Expand Down

0 comments on commit 105bb38

Please sign in to comment.