Fix error when opening file outside of any workspace #3815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`path.relative` doesn't allow `undefined` as its parameter(s) However this happens when `getWorkspaceDirs` returns an empty array. So extract the first element and check if it is valid/set before further processing.
✅ Deploy Preview for continuedev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
RomneyDa
requested changes
Jan 30, 2025
| const [rootDirectory] = await this.ide.getWorkspaceDirs(); | ||
| if (!rootDirectory) | ||
| return; // Not in a workspace | ||
| const relativeFilePath = path.relative(rootDirectory, filepath); |
There was a problem hiding this comment.
@Flamefire super delayed review, sorry
ide.getWorkspaceDirs returns URIs, not paths, so the path.relative logic will fail. Can you update to use the findUriInDirs util in core/util/uri.ts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
path.relativedoesn't allowundefinedas its parameter(s)However this happens when
getWorkspaceDirsreturns an empty array which causes an error:So extract the first element and check if it is valid/set before further processing.
Testing instructions
Open a single file in VSCode and observe that the error message is no longer shown