Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix VSCode API: run config reload with additional context providers #3845

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ajshedivy
Copy link
Contributor

Description

Fix for #3678

This pull request introduces changes to the configuration handling in the core/config module. The main improvements include adding support for additional context providers during the configuration reload process.

Key changes:

Configuration Handling Enhancements:

  • core/config/ConfigHandler.ts: Modified the reloadConfig method to accept an array of IContextProvider as an optional parameter. This allows for additional context providers to be passed during the reload process.
  • core/config/ConfigHandler.ts: Updated the registerCustomContextProvider method to pass the additionalContextProviders array when calling reloadConfig.
  • core/config/ProfileLifecycleManager.ts: Updated the reloadConfig method to accept an array of IContextProvider as an optional parameter and pass it to the loadConfig method.

Checklist

  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screenshots

[ For visual changes, include screenshots. ]

Testing instructions

To test this fix, follow the instructions described in the issue #3678

Copy link

netlify bot commented Jan 25, 2025

Deploy Preview for continuedev ready!

Name Link
🔨 Latest commit 07c0913
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/679db7d19f424f00087dc204
😎 Deploy Preview https://deploy-preview-3845--continuedev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Patrick-Erichsen
Copy link
Collaborator

Patrick-Erichsen commented Jan 27, 2025

Nice catch, thanks for taking the time to fix this @ajshedivy !

Trying to figure out why the e2e tests are all failing here, think it is a permissions issue

@ajshedivy
Copy link
Contributor Author

@Patrick-Erichsen I noticed some other PRs had similar test failures:

@sestinj sestinj temporarily deployed to tests-requiring-secrets February 1, 2025 05:57 — with GitHub Actions Inactive
@sestinj sestinj temporarily deployed to tests-requiring-secrets February 1, 2025 05:58 — with GitHub Actions Inactive
@sestinj sestinj temporarily deployed to tests-requiring-secrets February 1, 2025 06:00 — with GitHub Actions Inactive
@sestinj sestinj temporarily deployed to tests-requiring-secrets February 1, 2025 06:00 — with GitHub Actions Inactive
@sestinj sestinj temporarily deployed to tests-requiring-secrets February 1, 2025 06:00 — with GitHub Actions Inactive
@sestinj sestinj temporarily deployed to tests-requiring-secrets February 1, 2025 06:00 — with GitHub Actions Inactive
@sestinj sestinj temporarily deployed to tests-requiring-secrets February 1, 2025 06:00 — with GitHub Actions Inactive
@sestinj sestinj temporarily deployed to tests-requiring-secrets February 1, 2025 06:00 — with GitHub Actions Inactive
@sestinj sestinj temporarily deployed to tests-requiring-secrets February 1, 2025 06:00 — with GitHub Actions Inactive
@sestinj sestinj temporarily deployed to tests-requiring-secrets February 1, 2025 06:00 — with GitHub Actions Inactive
@sestinj sestinj temporarily deployed to tests-requiring-secrets February 1, 2025 06:00 — with GitHub Actions Inactive
@sestinj sestinj temporarily deployed to tests-requiring-secrets February 1, 2025 06:00 — with GitHub Actions Inactive
@sestinj sestinj temporarily deployed to tests-requiring-secrets February 1, 2025 06:00 — with GitHub Actions Inactive
@sestinj sestinj temporarily deployed to tests-requiring-secrets February 1, 2025 06:00 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants