Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send uris to model, fix jetbrains current file #3893

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Jan 29, 2025

Fixe security and consistency issues with context providers

  • Make context providers (currentFile, file, current file from resolveInput) consistent: description = last 2 path parts, codeblock header = full relative path, name = basename
  • Removes "getCurrentFile" webview to IDE call - uses currentFile context provider for more consistency. This Fixes for jetbrains because was the only remaining message direct from webview to ide that didn't have the new messaging format but was coming from both core and webview so couldn't trivally wrap with e.g. { status, done, content }

Copy link

netlify bot commented Jan 29, 2025

Deploy Preview for continuedev ready!

Name Link
🔨 Latest commit c89e3ca
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/679d301f302e34000800b5ac
😎 Deploy Preview https://deploy-preview-3893--continuedev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 20:18 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 20:19 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 20:21 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 20:21 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 20:21 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 20:21 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 20:21 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 20:21 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 20:21 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 20:21 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 20:21 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 20:21 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 20:21 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 20:21 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant