Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: extra quotes in COOLIFY_CONTAINER_NAME environment variable for compose deployments #4931

Open
nktnet1 opened this issue Jan 23, 2025 · 0 comments · May be fixed by #4933
Open

[Bug]: extra quotes in COOLIFY_CONTAINER_NAME environment variable for compose deployments #4931

nktnet1 opened this issue Jan 23, 2025 · 0 comments · May be fixed by #4933
Labels
🐛 Bug Reported issues that need to be reproduced by the team. 🔍 Triage Issues that need assessment and prioritization.

Comments

@nktnet1
Copy link
Contributor

nktnet1 commented Jan 23, 2025 •
edited
Loading

Error Message and Logs

I discovered this while trying to create a container for superset in #4891:

This also occurs when deploying from existing templates, e.g. IT Tools:

However, oddly, it wasn't an issue in an application deployment (NextJS from private Github repo):

Steps to Reproduce

  1. Create a resource from a template or docker-compose
  2. Open a terminal
  3. Run the command echo $COOLIFY_CONTAINER_NAME
  4. Observe the extra quotes in the variable

Coolify Version

v4.0.0-beta.387

Are you using Coolify Cloud?

No (self-hosted)

Operating System and Version (self-hosted)

Arch Linux x86_64 6.12.8-arch1-1

Additional Information

This issue likely stems from here:

coolify/app/Jobs/ApplicationDeploymentJob.php

Lines 926 to 928 in 86e14f3

if ($this->application->environment_variables_preview->where('key', 'COOLIFY_CONTAINER_NAME')->isEmpty()) {
$envs->push("COOLIFY_CONTAINER_NAME=\"{$this->container_name}\"");
}

and/or here:

coolify/app/Jobs/ApplicationDeploymentJob.php

Lines 985 to 987 in 86e14f3

if ($this->application->environment_variables->where('key', 'COOLIFY_CONTAINER_NAME')->isEmpty()) {
$envs->push("COOLIFY_CONTAINER_NAME=\"{$this->container_name}\"");
}

Digging online, this could potentially be related to:
@nktnet1 nktnet1 added 🐛 Bug Reported issues that need to be reproduced by the team. 🔍 Triage Issues that need assessment and prioritization. labels Jan 23, 2025
@nktnet1 nktnet1 changed the title [Bug]: extra quotes in COOLIFY_CONTAINER_NAME environment variable [Bug]: extra quotes in COOLIFY_CONTAINER_NAME environment variable for compose deployments Jan 23, 2025
@nktnet1 nktnet1 linked a pull request Jan 23, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 Bug Reported issues that need to be reproduced by the team. 🔍 Triage Issues that need assessment and prioritization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove quotes in COOLIFY_CONTAINER_NAME nktnet1/coolify
1 participant
@nktnet1