Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove quotes in COOLIFY_CONTAINER_NAME #4933

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove quotes in COOLIFY_CONTAINER_NAME #4933

wants to merge 1 commit into from
+3 −3

Conversation

nktnet1
Copy link
Contributor

@nktnet1 nktnet1 commented Jan 23, 2025

Changes

  • remove quotes from COOLIFY_CONTAINER_NAME quotes

Before:
image

After:
it-tools-container-name-after

Issues

Note:

Seeing that container names are generated using service-<uuid>, and that it is being escaped in places like:

coolify/app/Jobs/ApplicationDeploymentJob.php

Lines 938 to 942 in 08f7fa2

if ($env->is_literal || $env->is_multiline) {
$real_value = '\''.$real_value.'\'';
} else {
$real_value = escapeEnvVariables($env->real_value);
}

I assume this is okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: extra quotes in COOLIFY_CONTAINER_NAME environment variable for compose deployments
1 participant
@nktnet1