Skip to content

Commit

Permalink
fix gcd mods
Browse files Browse the repository at this point in the history
  • Loading branch information
coolmodi committed Nov 20, 2020
1 parent 88990c4 commit 61621a9
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 7 deletions.
4 changes: 1 addition & 3 deletions core/core.lua
Original file line number Diff line number Diff line change
Expand Up @@ -257,8 +257,7 @@ local function CalcSpell(spellId, calcedSpell, parentSpellData, parentEffCastTim

if parentEffCastTime == nil then
if stats.gcdMods[spellId] ~= nil then
-- TODO: this should probably be / 1000
GCD = GCD + stats.gcdMods[spellId].val / 100;
GCD = GCD + stats.gcdMods[spellId].val / 1000;
calcedSpell:AddToBuffList(stats.gcdMods[spellId].buffs);
end

Expand Down Expand Up @@ -522,7 +521,6 @@ local function CalcSpell(spellId, calcedSpell, parentSpellData, parentEffCastTim

--------------------------
-- Handle triggered spell effect
-- TODO: for dmg spells use mitigation (NOT RESIST) values from triggering spell in triggered spell calc

do
local triggerFromSpell = spellId;
Expand Down
1 change: 0 additions & 1 deletion core/effectHandlers.lua
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,6 @@ local function ManaShield(calcedSpell, effNum, spellBaseInfo, spellRankInfo, eff
calcedEffect.perResource = calcedEffect.avgAfterMitigation / calcedSpell.effectiveCost;
end

-- TODO: test with searing totem (2 levels to go!)
--- Handler for things like Arcane Missiles or Searing Totem.
--- That is, periodic spells with ticks that behave much like a direct damage effect.
---@param calcedSpell CalcedSpell
Expand Down
2 changes: 0 additions & 2 deletions data/auras.lua
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,6 @@ _addon.buffData = {
effect = _addon.EFFECT_TYPE.MP5,
value = 12,
},

-- TODO: Other buffs that are outside the scope of base API queries
};

-- Buffs the target can have (NYI)
Expand Down
1 change: 0 additions & 1 deletion data/itemEffects.lua
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,5 @@ _addon.itemEffects = {
value = 0
}
},
-- TODO: https://classic.wowhead.com/item=23197/idol-of-the-moon
-- TODO: https://classic.wowhead.com/item=23004/idol-of-longevity
}

0 comments on commit 61621a9

Please sign in to comment.