Allow waiting until the pool is ready #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sandfox any updates? |
idan-at
pushed a commit
to idan-at/thread-pool-node
that referenced
this pull request
Aug 26, 2019
More info here: coopernurse/node-pool#268. Once this PR will be merged, I will update generic-pool version and revert this commit.
|
@Kikobeats Can you please have a look? |
|
@idan-at let me take a look. BTW, can you remove |
|
@Kikobeats Thanks.
Done. |
|
LGTM; Can you add the |
|
Makes sense :) Done here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be useful to wait for the pool to be ready.
For example, a web server can listen only after the pool is "warmed".
solves #265 .