[16.0][MIG] delivery_product_restriction: migration to 16.0 #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carmen Bianca Bakker <[email protected]>
call super() instead of re-implementing the default logic, to ensure that other modules can also override it (like delivery_multi_destination, for instance).
huguesdk
force-pushed
the
16.0-mig-delivery_product_restriction
branch
from
80a9395 to
b4d1d2f
Compare
polchampion
reviewed
Dec 6, 2024
There was a problem hiding this comment.
@huguesdk Tested on rotor-v16-test ; I can't get it to work in the backend
- I restricted this product to this carrier
- Yet I can select the carrier on this picking
[edit] In odoo standard, the delivery method is not displayed on the SO, so not sure how to test the behaviour.
|
@polchampion thanks for the functional test. this module only works in the backend. the behavior has changed between version 12.0 and 16.0:
is this behavior enough or do you think it should behave differently? if you think that it’s ok, i’ll update the readme because i had a hard time understanding again how it is working even though it was i who ported the module. 😅 |
* refactor to use super() as much as possible instead of copying overridden code. * remove default delivery carrier of the delivery wizards if it cannot be used for the sale order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
odoo task
t12912