Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent user select on container-body #340

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

barbalex
Copy link

@barbalex barbalex commented May 8, 2024

When logging in, focus drops into the container-body, thus the cursor blinks next to the title, watch "Log in":

with_user_select.mp4

I find this distracting. This pull request prevents that by preventing user-selection:

without_user_select.mp4

@incorbador
Copy link
Contributor

Hey @barbalex. Thanks for the PR.
On what environment are you experiencing this issue? (OS, browser, are you using a JavaScript or a CSS Framework)?

@barbalex
Copy link
Author

barbalex commented May 8, 2024

  • os: windows 11 up to date
  • browser: chrome up to date
  • javascript framework (if you want to call it that): react (without meta-framework)
  • css-framework: none

@incorbador
Copy link
Contributor

Ok, thanks for the info. I can not reproduce the issue myself on the environment you described (tried a few windows devices where it did not show up).
I would just like to understand how this can happen.
Are you using any extension in your browser that might have something to do with this?

@barbalex
Copy link
Author

barbalex commented May 8, 2024

I tried deactivating all extensions. The behavior remains if I uncomment:

.cb-container-body {
  /* user-select: none; */
}

@incorbador
Copy link
Contributor

Is your application deployed somewhere, so that we can test it as well? Btw. you can just overwrite the class with your custom styling by defining a custom theme as described here: https://docs.corbado.com/frontend-integration/ui-components/customization#2-custom-styling

This might be a good quick fix in the meantime until we soft this out :)

@barbalex
Copy link
Author

barbalex commented May 9, 2024

Is your application deployed somewhere, so that we can test it as well

Unfortunately no, it is being developed

you can just overwrite the class with your custom styling by defining a custom theme as described here

Thanks, that is neat. I was overriding you classes but this is better

@barbalex
Copy link
Author

barbalex commented May 9, 2024

I now tried to test it on firefox (up to date).

The problem here is:
try_again

I can continue without passkeys (nice) but then I can't compare with the behaviour on chrome.

@barbalex
Copy link
Author

barbalex commented May 9, 2024

I also tried using edge. That directly uses windows hello and skips the Log in page completely. Nice. But not helpful to compare...

Edge also offers to use a passkey on another device. When clicking that it directly logs in. Some nice black magic going on there...

@barbalex
Copy link
Author

barbalex commented May 9, 2024

Don't hesitate to close the issue if you feel it must be a problem caused by something in my chrome browser. I can't say it that is the case but it seems possible 😢

@barbalex
Copy link
Author

barbalex commented May 9, 2024

I also tried using edge. That directly uses windows hello and skips the Log in page completely

Seems that chrome can do that too. nice.

@barbalex
Copy link
Author

barbalex commented May 9, 2024

By the way: I like the new looks of version 2

@incorbador
Copy link
Contributor

Hey, let me make sure that I get everything. What I understand is this:

  • You are experiencing an error when you try to create (not login) a passkey on Firefox (Windows 11) => is passkey creation always failing or is it a sporadic error? I will then try to reproduce that issue
  • You are also testing login with passkey on Edge and Chrome => What do you mean exactly by "That directly uses windows hello and skips the Log in page completely"? (another short screen recording might help here)

@barbalex
Copy link
Author

You are experiencing an error when you try to create (not login) a passkey on Firefox (Windows 11) => is passkey creation always failing or is it a sporadic error?

It is always failing. Here the screen recording:

firefox.mp4

@barbalex
Copy link
Author

barbalex commented May 10, 2024

I tried to demo logging in on edge. And managed to get the same error as on firefox. But with better error message:

e InvalidStateError The user attempted to register an authenticator that contains one of the credentials already registered with the relying party.

To start from a clean slate (?) I had removed all application state beforehand.

Also: I can click Continue without passkeys and then I am logged in. But from this moment on every login provokes an email being sent with a one-time passcode.

@barbalex
Copy link
Author

You are also testing login with passkey on Edge and Chrome => What do you mean exactly by "That directly uses windows hello and skips the Log in page completely"?

This:

edge.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants