-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prevent user select on container-body #340
base: develop
Are you sure you want to change the base?
Conversation
Hey @barbalex. Thanks for the PR. |
|
Ok, thanks for the info. I can not reproduce the issue myself on the environment you described (tried a few windows devices where it did not show up). |
I tried deactivating all extensions. The behavior remains if I uncomment: .cb-container-body {
/* user-select: none; */
} |
Is your application deployed somewhere, so that we can test it as well? Btw. you can just overwrite the class with your custom styling by defining a custom theme as described here: https://docs.corbado.com/frontend-integration/ui-components/customization#2-custom-styling This might be a good quick fix in the meantime until we soft this out :) |
Unfortunately no, it is being developed
Thanks, that is neat. I was overriding you classes but this is better |
I also tried using edge. That directly uses windows hello and skips the Edge also offers to use a passkey on |
Don't hesitate to close the issue if you feel it must be a problem caused by something in my chrome browser. I can't say it that is the case but it seems possible 😢 |
Seems that chrome can do that too. nice. |
By the way: I like the new looks of version 2 |
Hey, let me make sure that I get everything. What I understand is this:
|
It is always failing. Here the screen recording: firefox.mp4 |
I tried to demo logging in on edge. And managed to get the same error as on firefox. But with better error message: e InvalidStateError The user attempted to register an authenticator that contains one of the credentials already registered with the relying party. To start from a clean slate (?) I had removed all application state beforehand. Also: I can click |
This: edge.mp4 |
When logging in, focus drops into the container-body, thus the cursor blinks next to the title, watch "Log in":
with_user_select.mp4
I find this distracting. This pull request prevents that by preventing user-selection:
without_user_select.mp4