This repository was archived by the owner on Mar 18, 2019. It is now read-only.
Create universal wheels #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the generated wheel was only for the version of Python under which the `setup.py publish` command was run, which means the Python 3 wheel was missing for the latest release: https://pypi.python.org/pypi/coreschema/0.0.4
|
After #14 lands, you could include the license file in the generated wheel using the [metadata]
license_file = LICENSESee the documentation for information on this feature of wheel: https://wheel.readthedocs.io/en/stable/#including-the-license-in-the-generated-wheel-file This would satisfy the license's requirement:
|
|
Hi! That seems orthogonal to this PR? Wheels are already being created; this PR just makes sure they are created for both Python 2 and 3, not just one of Python {2, 3}. As such, it's probably best as a new issue (or a comment on #14), rather than here. |
|
@tomchristie, don't suppose you could merge this? :-) |
|
Ping? :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the generated wheel was only for the version of Python under which the
setup.py publishcommand was run, which means the Python 3 wheel was missing for the latest release:https://pypi.python.org/pypi/coreschema/0.0.4