Extra test vectors #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This splits the example into what the URI said (there is a query parameter) and what the CRI said (there is a question mark in the path).
|
Is there any discussion necessary on whether these changes are correct, or can we just merge this? |
|
I've updated my Rust implementation (some cleanup needed before pushing), and it passes with these vectors and I found no new issues from making it work. |
|
One more commit now adds a test for PET in the host name; I found that necessary for feature coverage in the Rust implementation (but they pass in the Python impl as well). |
chrysn
commented
Jun 21, 2022
The empty array is clearly described to mean discard-nothing. A separate test case that duplicated the previously existing explicit `[0]` case is removed. (So that there are now "only" 2 CRIs equivalent to the URI <>).
|
Takeaway from today's meeting: "invalid" should be classified (without ruling out that weird cases stay weird until our mental model of how things can be wrong in a CRI has been enhanced) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now for some hard ones...
This introduces two things on the mechanism side:
That being said, these tests are what I needed to get OKish coverage, and to flush out places where I knew my implementation was incomplete. It contains PETs and non-PET things that do or do not need escaping in a lot of places, plus tests for things that will get separate issues shortly (like the last one)