Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip threads in case of tagged interfaces #13

Closed
wants to merge 3 commits into from

Conversation

vpiserchia
Copy link

This is only a workaround for #12 waiting for upstream to fix this misbehavior.

@awelzel
Copy link
Collaborator

awelzel commented Feb 4, 2024

Hey @vpiserchia - thanks for the PR! Much appreciated. The "capture" entry can legitimately not be included if I remember correctly (for example if a Napatech card is used).

Could you check for "tcp" instead and also log a warning when this happens including the name of the entry? Possibly extend the tests with you dump-counters.json file so we can make sure it won't crash in the future.

If you don't have the cycles, let me know and I'll pick it up.

@vpiserchia
Copy link
Author

@awelzel added workaround and test data. Please let me know if there is a better way since I'm not so fluent in golang

@awelzel
Copy link
Collaborator

awelzel commented Feb 6, 2024

@vpiserchia , thanks. I've opened a PR on the Suricata side. If that one moves quickly, I'd actually prefer to avoid this workaround in the exporter. Can you use your change locally for now?

I suppose you could also rename the bond interface (or create an alias?).

@vpiserchia
Copy link
Author

suricata merge process is known to not be that quick still I can surely use a local version of the exporter

@awelzel
Copy link
Collaborator

awelzel commented Feb 17, 2024

@vpiserchia - I'm closing this. Upcoming Suricata 7.0.4 should have this fixed. Thanks for the report.

@awelzel awelzel closed this Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants