add django 1.10 compability #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-erickson
suggested changes
Jan 12, 2017
| @@ -1,6 +1,6 @@ | |||
| import json | |||
|
|
|||
| from django.conf.urls import patterns, url | |||
| from django.conf.urls import url | |||
There was a problem hiding this comment.
patterns is referenced below, how does this work?
| handler: '{% url "admin:quill-file-upload" %}', | ||
| allowedExtensions: JSON.parse('{{ "allowed_image_extensions"|quill_conf_json }}') | ||
| allowedExtensions: JSON.parse('{{ "allowed_image_extensions"|quill_conf_json }}'), | ||
| // handler: '{% url "admin:quill-file-upload" %}', #Commented this our because trown an error. |
There was a problem hiding this comment.
This isn't a viable solution, without an explanation. Commenting out code isn't a preferred practice either.
| @@ -1,6 +1,6 @@ | |||
| from django import forms | |||
| from django.apps import apps | |||
| from django.forms.util import flatatt | |||
| from django.forms.utils import flatatt | |||
There was a problem hiding this comment.
This won't work for older versions of Django.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django 1.9 renamed "django.forms.util" to "django.forms.utils". And use of
patternsis also deprecated since django 1.8. You can use plain lists now.