Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade quill.js to latest version #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

upgrade quill.js to latest version #8

wants to merge 1 commit into from

Conversation

imagescape
Copy link

This upgrade should allow the ability to create a link that opens in a separate tab vs in the same browser window. If it does, it is not obvious how this should be accomplished. Operation seems the same as before the upgrade.

@chris-erickson
Copy link

I'm just going to dump some notes I have in here that outline what's needed to update Quill. Unfortunately, it's not as simple as just updating the NPM dependency.

# Developing
- Checkout the repo local to the Django project in question
- Install Quill with pip using the link method (uninstall the old one potentially):
    - pip install -e django-quill/
- Install npm dependencies
    - npm install
- Copy static files
    - ./manage.py collectstatic

As you make changes to the JS, you will need to build them using
    - make build

Then you need to copy the files in django again, with collectstatic

Finally, you need use your final, built code and create the pypi and git tags/github release.  This isn't well documented, unfortunately.

# Some Updates Required for Version Bump:
- Update Quill npm dependencies
- Update js API calls (there's a handful of errors in the console) with the current config
    - `django-quill/quill/static/quill/js/image.js` needs to change the registerModule call to register
    - More needed in terms of setting up the modules
- Get the new built vendor CSS file, which can be located at some thing like `https://cdn.quilljs.com/1.1.10/quill.snow.css` if you don't want to build it yourself
- Update the django Suit related CSS in `django-quill/quill/static/quill/css/quill.css` as needed

The recent versions of Quill are quite nice, and are really a much better alternative to CKEditor, etc in some ways. This would be an excellent opportunity for the community to take on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants