Fix #106: Fix wrongly filtered out packages when using --versioned-dirs #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
reviewed
Oct 18, 2024
|
|
||
| if packages.contains_key(&first.id) { | ||
| package_filenames.insert(Cow::Borrowed(first.name.as_str()), *first); | ||
| // If we use versioned-dirs, we insert all packages with a versioned filename |
There was a problem hiding this comment.
Ah yes...I should have double checked this. It's not surprising this logic needed to change.
Yeah agree. |
msirringhaus
force-pushed
the
fix_versioned_dirs
branch
from
f0e76b0 to
7607a55
Compare
cgwalters
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have not (yet) made
--versioned-dirsthe default, as I think we might want to have a separate discussion about this.As I'm not clear on the following question:
Once it's the default, should
--versioned-dirsbe a no-op flag, or should the user still be able to DEactivate that feature? Depending on the answer, we can or can't remove the decision-code I added.