Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image/blob tagging functionality to ore #3915

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 69 additions & 0 deletions mantle/cmd/ore/aws/tag-image.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
// Copyright 2017 CoreOS, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package aws

import (
"fmt"
"os"
"strings"

"github.com/spf13/cobra"
)

var (
cmdTagImage = &cobra.Command{
Use: "tag-image --ami <ami_id> --tags foo=bar ...",
Short: "Tag an AMI",
Run: runTagImage,
}
tags []string
)

func init() {
// Initialize the command and its flags
AWS.AddCommand(cmdTagImage)
cmdTagImage.Flags().StringVar(&amiID, "ami", "", "AWS AMI ID")
cmdTagImage.Flags().StringVar(&region, "region", "", "Region")
cmdTagImage.Flags().StringSliceVar(&tags, "tags", []string{}, "list of key=value tags to attach to the AMI")
}

func runTagImage(cmd *cobra.Command, args []string) {
if amiID == "" {
fmt.Fprintf(os.Stderr, "Provide --ami to tag\n")
os.Exit(1)
}

if region == "" {
fmt.Fprintf(os.Stderr, "Provide --region\n")
os.Exit(1)
}

tagMap := make(map[string]string)
for _, tag := range tags {
splitTag := strings.SplitN(tag, "=", 2)
if len(splitTag) != 2 {
fmt.Fprintf(os.Stderr, "invalid tag format; should be key=value, not %v\n", tag)
os.Exit(1)
}
key, value := splitTag[0], splitTag[1]
tagMap[key] = value
}
Comment on lines +53 to +62
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: feels like we should just lower this into API.CreateTags() so that it's deduped with ore aws upload --tags.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly for the others.


err := API.CreateTags([]string{amiID}, tagMap)
if err != nil {
fmt.Fprintf(os.Stderr, "couldn't create image tags: %v", err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\n

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And similarly for the other files.

os.Exit(1)
}
}