testiso: add new PXE tests instead of '--pxe-append-rootfs' switch #4031
Conversation
|
Or another way - coreos/coreos-ci-lib#162 |
nikita-dubrovskii
force-pushed
the
pxe_appended_rootfs
branch
from
279fe55 to
a490999
Compare
|
Thanks @nikita-dubrovskii - this LGTM. We can merge after our FCOS releases go out this week. One suggestion I have is that we don't actually add more testiso tests as part of this, but rather repurpose existing ones (trying to get coverage of the various scenarios across the architectures). WDYT of something like this: diff --git a/mantle/cmd/kola/testiso.go b/mantle/cmd/kola/testiso.go
index 709bcbf1c..2eaeb0613 100644
--- a/mantle/cmd/kola/testiso.go
+++ b/mantle/cmd/kola/testiso.go
@@ -96,23 +96,21 @@ var (
"miniso-install.nm.bios",
"miniso-install.4k.uefi",
"miniso-install.4k.nm.uefi",
- "pxe-offline-install.bios",
+ "pxe-offline-install.rootfs-appended.bios",
"pxe-offline-install.4k.uefi",
"pxe-online-install.bios",
"pxe-online-install.4k.uefi",
- "pxe-offline-install.rootfs-appended.uefi",
}
tests_s390x = []string{
"iso-live-login.s390fw",
"iso-offline-install.s390fw",
"iso-offline-install.mpath.s390fw",
"iso-offline-install.4k.s390fw",
- "pxe-online-install.s390fw",
+ "pxe-online-install.rootfs-appended.s390fw",
"pxe-offline-install.s390fw",
"miniso-install.s390fw",
"miniso-install.nm.s390fw",
"miniso-install.4k.nm.s390fw",
- "pxe-offline-install.rootfs-appended.s390fw",
// FIXME https://github.com/coreos/fedora-coreos-tracker/issues/1657
//"iso-offline-install-iscsi.ibft.s390fw,
//"iso-offline-install-iscsi.ibft-with-mpath.s390fw",
@@ -127,9 +125,8 @@ var (
"miniso-install.nm.ppcfw",
"miniso-install.4k.ppcfw",
"miniso-install.4k.nm.ppcfw",
- "pxe-online-install.ppcfw",
- "pxe-offline-install.4k.ppcfw",
"pxe-offline-install.rootfs-appended.ppcfw",
+ "pxe-offline-install.4k.ppcfw",
// FIXME https://github.com/coreos/fedora-coreos-tracker/issues/1657
//"iso-offline-install-iscsi.ibft.ppcfw",
//"iso-offline-install-iscsi.ibft-with-mpath.ppcfw",
@@ -146,10 +143,9 @@ var (
"miniso-install.4k.uefi",
"miniso-install.4k.nm.uefi",
"pxe-offline-install.uefi",
- "pxe-offline-install.4k.uefi",
+ "pxe-offline-install.rootfs-appended.4k.uefi",
"pxe-online-install.uefi",
"pxe-online-install.4k.uefi",
- "pxe-offline-install.rootfs-appended.uefi",
// FIXME https://github.com/coreos/fedora-coreos-tracker/issues/1657
//"iso-offline-install-iscsi.ibft.uefi",
//"iso-offline-install-iscsi.ibft-with-mpath.uefi",
|
What's the goal? Reducing overall test time? I prefer more different tests |
The goal is to have a balance of test coverage versus time spent doing tests. The testiso tests are already over an hour in our pipeline runs. In a world where we had infinite resources I would agree with you, but practically I'd prefer to not add to our testiso test load here. cc @jlebon for another opinion. |
nikita-dubrovskii
force-pushed
the
pxe_appended_rootfs
branch
from
a490999 to
60478fb
Compare
|
@dustymabe, Done, now it's just a suffix to existing tests |
|
This LGTM. weird.. CI is showing: but it's not even on the testiso tests.. |
The `kola testiso` command supported `--pxe-append-rootfs`, but it was never used in CI, and probably was also ignored by developers. This PR drops that switch and adds 1 new test for each arch: - pxe-[online|offline]-install.rootfs-appended
nikita-dubrovskii
force-pushed
the
pxe_appended_rootfs
branch
from
60478fb to
7aeef57
Compare
Locally haven't seen this. Rebased , let's see if this occurs again |
|
another CI failure happened that looks unrelated :( Do you mind looking into that one? maybe the toolbox container in the remote registry is broken? |
The
kola testisocommand supported--pxe-append-rootfs, but it was never used in CI, and probably was also ignored by developers. This PR drops that switch and adds 1 new test for each arch: