cmd-remote-build-container: Add support for secret, mount-host-ca-cer… #4033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlebon
reviewed
Mar 3, 2025
ravanelli
force-pushed
the
pr/remote-build
branch
from
7c73dd6 to
4439d9a
Compare
jlebon
previously approved these changes
Mar 4, 2025
src/cmd-remote-build-container
Outdated
| parser.add_argument( | ||
| '--repo', default='localhost', required=False, | ||
| help='Registry repository') | ||
| parser.add_argument( | ||
| '--secret', required=False, action='append', default=[], | ||
| help='Provide a local secret for remote access. Uses the same syntax as podman --secret') |
There was a problem hiding this comment.
Suggested change
| help='Provide a local secret for remote access. Uses the same syntax as podman --secret') | |
| help='Provide a local secret for remote access. Uses the same syntax as `podman build --secret`') |
src/cmd-remote-build-container
Outdated
| help='Provide a local secret for remote access. Uses the same syntax as podman --secret') | ||
| parser.add_argument( | ||
| '--security-opt', required=False, | ||
| help='Set SELinux options. Uses the same syntax as podman --security-opt') |
There was a problem hiding this comment.
Suggested change
| help='Set SELinux options. Uses the same syntax as podman --security-opt') | |
| help='Set SELinux options. Uses the same syntax as `podman build --security-opt`') |
…ts, and security-opt parameters - Allow passing secret files and SELinux labels in remote builds. - Enable mounting the host's CA certificates, as they are already available by default on the host. Signed-off-by: Renata Ravanelli <[email protected]>
ravanelli
force-pushed
the
pr/remote-build
branch
from
4439d9a to
0c8dad0
Compare
jlebon
approved these changes
Mar 5, 2025
jlebon
reviewed
Mar 5, 2025
Comment on lines
+34
to
+36
| if secret: | ||
| for s in secret: | ||
| cmd.append(f"--secret={s}") |
There was a problem hiding this comment.
I guess this could be just
for secret in secrets:
cmd.append(f"--secret={secret}")but not worth the respin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ts, and security-opt parameters