Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use '--tty-' for podman shell aliases #341

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Conversation

travier
Copy link
Member

@travier travier commented Dec 2, 2021

Using '--tty' conflicts with stdin redirection:
https://docs.podman.io/en/latest/markdown/podman-run.1.html#tty-t

@travier
Copy link
Member Author

travier commented Dec 2, 2021

We probably still need it for coreos-installer to be able to cancel downloads.

Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@bgilbert bgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coreos-installer has a weird tradeoff: we need a TTY to cancel downloads, but need to not have one for the caller to retrieve the path to the downloaded file.

So yeah, might as well convert everything for consistency,

@travier
Copy link
Member Author

travier commented Dec 3, 2021

I'd opt for keeping things simple here in the tutorial and adding the details to the coreos-installer docs: coreos/coreos-installer#703

@travier travier merged commit f7ddc4b into coreos:main Dec 8, 2021
@travier travier deleted the notty branch December 8, 2021 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants