-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
providers: support for vendor-data in proxmoxve #2014
base: main
Are you sure you want to change the base?
Conversation
0d7040f
to
f60d7f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more comment, otherwise LGTM.
Can you squash all your commits into the first?
3ce4656
to
4849d9c
Compare
Feedback applied and commits squashed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nits; lgtm
For the commit message I think it might sound clearer if we remove the details about the pr.
wdyt about
"Add support for reading Ignition data out of the
vendor-data file. No longer clobber the user-data file."
?
vendor-data file. No longer clobber the user-data file."
4849d9c
to
9238e0f
Compare
Feedback applied. Please let's merge this. :) |
Thank you, I am trying to work through the failing CI. Locally having some issues with golang so it might take me a few moments. |
deviceLabel = "cidata" needs some spaces gofmt is not allowing builds. You can fix this by running gofmt on the proxmoxve file. |
This PR adds support for reading Ignition data out of the vendor-data file so we can leave the cloud-config in the user-data file. It will always use the user-data file if it has an ignition config over using the vendor-data file.
This works as expected: