Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fcos/release-checklist: issue template changes #284

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

marmijo
Copy link
Member

@marmijo marmijo commented Mar 6, 2025

GitHub now requires issue templates to contain yaml front matter and be located in .github/ISSUE_TEMPLATE/ to be properly detected as a template.

Add the required 'name' and 'about' fields in the yaml front matter and also add 'title' and 'labels' to assist with release checklist creation.

See:

GitHub now requires issue templates to contain yaml front matter and be located
in `.github/ISSUE_TEMPLATE/` to be properly detected as a template.

Add the required 'name' and 'about' fields in the yaml front matter and also add
'title' and 'labels' to assist with release checklist creation.
@marmijo marmijo force-pushed the fcos-template-fix branch from 197fa9d to dd4b348 Compare March 6, 2025 21:25
marmijo added a commit to marmijo/fedora-coreos-streams that referenced this pull request Mar 6, 2025
Move the ISSUE_TEMPLATE directory to .github so the changes from
coreos/repo-templates#284 can be synced to allow these
files to be used as templates again.
@@ -1,5 +1,10 @@
---
# Template generated by https://github.com/coreos/repo-templates; do not edit downstream
name: {{ stream }} release checklist
Copy link
Member Author

@marmijo marmijo Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the yaml front matter doesn't work with the {{ stream }} placeholder. The file should look like this after it's been rendered: https://github.com/marmijo/fedora-coreos-streams/blob/eda9d8d308e8f6252166d5f1e0def2f35b074598/.github/ISSUE_TEMPLATE/stable.md

@@ -155,5 +160,5 @@ NOTE: In the future, most of these steps will be automated.

## Housekeeping

- [ ] If one doesn't already exist, [open an issue](https://github.com/coreos/fedora-coreos-streams/issues/new?labels=kind/release,jira&template={{ stream }}.md) in this repo for the next release in this stream. Use the approximate date of the release in the title.
- [ ] If one doesn't already exist, [open an issue](https://github.com/coreos/fedora-coreos-streams/issues/new?template={{ stream }}.md) in this repo for the next release in this stream. Use the approximate date of the release in the title.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove the labels parameter now that the front matter takes care of adding them

Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

marmijo added a commit to coreos/fedora-coreos-streams that referenced this pull request Mar 6, 2025
Move the ISSUE_TEMPLATE directory to .github so the changes from
coreos/repo-templates#284 can be synced to allow these
files to be used as templates again.
@marmijo marmijo merged commit 354ebc7 into coreos:main Mar 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants