Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Courses (FA22-Nov1) #756

Merged
merged 4 commits into from
Nov 2, 2022
Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 1, 2022

Ran npm run courses-gen and npm run req-gen, as part of the update-courses workflow.

@github-actions github-actions bot requested a review from a team as a code owner November 1, 2022 23:36
@benjamin-shen
Copy link
Collaborator

benjamin-shen commented Nov 2, 2022

Unfortunately, the check job didn't run. I did some research and it seems to be a frequently encountered issue. According to these docs:

When you use the repository's GITHUB_TOKEN to perform tasks, events triggered by the GITHUB_TOKEN, with the exception of workflow_dispatch and repository_dispatch, will not create a new workflow run. This prevents you from accidentally creating recursive workflow runs. For example, if a workflow run pushes code using the repository's GITHUB_TOKEN, a new workflow will not run even when the repository contains a workflow configured to run when push events occur.

There are a couple options:

  • Use a dev's personal access token (PAT).
  • Have a dev push a no-op to the PR.
  • Change the CI check to also run on workflow_dispatch, and manually run the check job on automated PRs.
    • Only the check job is required to merge to master.
    • The downside of this is that the other non-check jobs that would normally run, such as snapshot deployment and ci policies, would not run. This is mostly not an issue because the update-courses workflow is so simple. But perhaps there should be another workflow_dispatch job that depends on (runs) every other job.

If anyone can think of any other solutions, please lmk!

@dti-github-bot
Copy link
Member

dti-github-bot commented Nov 2, 2022

[diff-counting] Significant lines: 8.

@github-actions
Copy link
Contributor Author

github-actions bot commented Nov 2, 2022

Visit the preview URL for this PR (updated for commit 3a48d86):

https://cornelldti-courseplan-dev--pr756-update-courses-fa22-yyc0ud0i.web.app

(expires Fri, 02 Dec 2022 03:51:15 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933

@benjamin-shen benjamin-shen changed the title [Automated] Update Courses (FA22-Nov1) Update Courses (FA22-Nov1) Nov 2, 2022
@benjamin-shen benjamin-shen merged commit 7673296 into master Nov 2, 2022
@benjamin-shen benjamin-shen deleted the update-courses/FA22-Nov1 branch November 2, 2022 04:45
@noschiff noschiff mentioned this pull request Nov 2, 2022
43 tasks
@noschiff noschiff added the automated Automated data label Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated Automated data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants