Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add generic documentation for pdf generation #949

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

Destaq
Copy link
Member

@Destaq Destaq commented Oct 24, 2024

Added in documentation for how PDFs are generated on CoursePlan, for reference for later developers or across the project team!

@Destaq Destaq requested a review from a team as a code owner October 24, 2024 15:37
@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 61.

Copy link
Contributor

Visit the preview URL for this PR (updated for commit 3cc6c68):

https://cornelldti-courseplan-dev--pr949-simon-pdf-generation-9nkeng5g.web.app

(expires Sat, 23 Nov 2024 15:39:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933

Copy link
Contributor

@nidhi-mylavarapu nidhi-mylavarapu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

documentation

^ not you considering how detailed your documentation is
thank you, simon!!

@Destaq Destaq merged commit e7a6e71 into main Oct 27, 2024
10 of 11 checks passed
@Destaq Destaq deleted the simon-pdf-generation-docs branch October 27, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants