-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Saved Courses Release! #958
Conversation
* [Saved Courses] add save modal (#912) * Change course menu to click state (#898) * add save button and icon * change position of save course button * added new Save Course Modal * added new Save Course Modal * added basic front-end look * re-edit teleport modal * fixed basic front-end look * renamed icon * fixed frontend alignment * fixed frontend alignment and file path * added feature flag for save course modal * fixed front-end bug and modal hierachy * change method and emit names --------- Co-authored-by: KaylinChan <[email protected]> * added collections in store. add backend methods and gtags * added basic functionality for save course - can save a course when press 'done' - course is saved to an empty collection - add functions for add & edit collection * fixed functionality for save courses to mutliple collections - can save one course to multiple collections w/ checkbox - saved course will be removed from semester view and from fullfilled requirements - pop up notification * finished backend and fixed frontend - finished scrollable checkbox frontend - fixed the bug for selecting a singular checkbox - believed its stored in firestore when added to collection - renamed collection to savedCourses for firesetore clarity * created editabilify for collection names - saveCourseModal allow user to name their new collections - moved scss into a separate file * fixed backend error and logic - added updateDoc in backend functions - made edit Collections modal more functional with saveCourse * [Saved Courses] Add Icon to Sidebar (#882) * add icon * fix icon * feature flag * fixed feature flags * collections page empty front-end look (#940) * added save-collection emit * create sidebar vue * connected dashboard and sidebar * finished empty front-end look * adjust hover * fixed positioning * update artifact version * added front-end look for saved courses in collection * fixed collectionsidebar css for frontend implementation * edit collection modal + front-end fixes - added edit collection modal and text input collection modal - fixed front-end with trash can - fixed front-end with dropdown button and edit collection button * frontend fixes - fixed padding - fixed null issue * added helper function in utilities * ran prettier * frontend fixes --------- Co-authored-by: Hannah Zhou <[email protected]> Co-authored-by: Hannah Zhou <[email protected]> * merged sidebar with backend * fixed migration script and bottom course bar * feat: draggable saved courses * chore: prettify things * ran prettier and type check * fixed cu review api * fixed div * remove feature flag * frontend and type check fixes * resolved front-end issue with plans * fixed more front-end and confirmation modal * fixed frontend * ran prettier * last fix --------- Co-authored-by: KaylinChan <[email protected]> Co-authored-by: andrew xu <[email protected]> Co-authored-by: Simon Ilincev <[email protected]> Co-authored-by: Simon Ilincev <[email protected]>
[diff-counting] Significant lines: 1444. This diff might be too big! Developer leads are invited to review the code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saved courses fr fr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!!
Visit the preview URL for this PR (updated for commit 275203e): https://cornelldti-courseplan-dev--pr958-main-5vqv5u3z.web.app (expires Fri, 29 Nov 2024 23:15:54 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933 |
[Saved Courses] add save modal ([Saved Courses] add save modal #912)
Change course menu to click state (Course Menu Frontend Fixes #898)
add save button and icon
change position of save course button
added new Save Course Modal
added new Save Course Modal
added basic front-end look
re-edit teleport modal
fixed basic front-end look
renamed icon
fixed frontend alignment
fixed frontend alignment and file path
added feature flag for save course modal
fixed front-end bug and modal hierachy
change method and emit names
added collections in store. add backend methods and gtags
added basic functionality for save course
[Saved Courses] Add Icon to Sidebar ([Saved Courses] Add Icon to Sidebar #882)
add icon
fix icon
feature flag
fixed feature flags
collections page empty front-end look (collections page empty front-end look #940)
added save-collection emit
create sidebar vue
connected dashboard and sidebar
finished empty front-end look
adjust hover
fixed positioning
update artifact version
added front-end look for saved courses in collection
fixed collectionsidebar css for frontend implementation
edit collection modal + front-end fixes
added helper function in utilities
ran prettier
frontend fixes
merged sidebar with backend
fixed migration script and bottom course bar
feat: draggable saved courses
chore: prettify things
ran prettier and type check
fixed cu review api
fixed div
remove feature flag
frontend and type check fixes
resolved front-end issue with plans
fixed more front-end and confirmation modal
fixed frontend
ran prettier
last fix
Summary
This pull request is the first step towards implementing feature Foo
Remaining TODOs:
Depends on #{number of PR}
Test Plan
Notes
Blockers
Breaking Changes