jsdomClient: don't parse unsuccessful http response bodies, throw sta…

…tus instead
cornerman · Aug 24, 2024 · edd2ee5 · edd2ee5
1 parent a04d05d
commit edd2ee5
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/jsdomClient/src/main/scala/HttpRpcTransport.scala b/jsdomClient/src/main/scala/HttpRpcTransport.scala
@@ -18,10 +18,12 @@ object HttpRpcTransport {
 
   def apply[F[_]: Async](config: F[HttpRequestConfig]): RequestTransport[String, F] = new RequestTransport[String, F] {
     override def apply(request: Request[String]): F[String] = for {
-      config <- config
-      url = s"${config.baseUri}/${request.method.traitName}/${request.method.methodName}"
+      config     <- config
+      url         = s"${config.baseUri}/${request.method.traitName}/${request.method.methodName}"
       requestArgs = new dom.RequestInit { headers = config.headers.toJSDictionary; method = dom.HttpMethod.POST; body = request.payload }
-      result <- Async[F].fromThenable(Async[F].delay[js.Thenable[String]](dom.fetch(url, requestArgs).`then`[String](_.text())))
+      response   <- Async[F].fromPromise(Async[F].delay(dom.fetch(url, requestArgs)))
+      _          <- Async[F].raiseWhen(!response.ok)(new Exception(s"HTTP error ${response.status}"))
+      result     <- Async[F].fromPromise(Async[F].delay(response.text()))
     } yield result
   }
 }