Fix request url for jsdomClient #251
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `/` is already contained in `baseUri`.
cornerman
reviewed
Aug 24, 2024
| @@ -19,7 +19,7 @@ object HttpRpcTransport { | |||
| def apply[F[_]: Async](config: F[HttpRequestConfig]): RequestTransport[String, F] = new RequestTransport[String, F] { | |||
| override def apply(request: Request[String]): F[String] = for { | |||
| config <- config | |||
| url = s"${config.baseUri}/${request.method.traitName}/${request.method.methodName}" | |||
| url = s"${config.baseUri}${request.method.traitName}/${request.method.methodName}" | |||
There was a problem hiding this comment.
Good catch!
How about we do config.baseUri.trimSuffix("/") to make sure there is non? So that it works when providing a baseUri without a trailing slash.
There was a problem hiding this comment.
sounds like too many heuristics for me...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
/is already contained inbaseUri.