Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Example): Update Segmentation Volume #1201

Merged
merged 4 commits into from
May 15, 2024

Conversation

jlopes90
Copy link
Contributor

@jlopes90 jlopes90 commented Apr 10, 2024

Context

Changes & Results

Testing

Example Segmentation Volume
https://deploy-preview-1201--cornerstone-3d-docs.netlify.app/live-examples/segmentationVolume.html

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] "OS:
  • [] "Node version:
  • [] "Browser:

Copy link

netlify bot commented Apr 10, 2024

Deploy Preview for cornerstone-3d-docs canceled.

Name Link
🔨 Latest commit dd9c514
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/6619653886c3e700097a9e3e

@jlopes90
Copy link
Contributor Author

Don't merge yet, only when I say

@jlopes90
Copy link
Contributor Author

@sedghi

Before

When loading dicom and segmentation, the segmentation is opposite or incorrect.

async function fetchDicom() {
    imageIds = await createImageIdsAndCacheMetaData(exConfig.fetchDicom);
    await loadDicom(imageIds);
}

image

After

I changed the loadDicom(imageIds) to loadDicom(imageIds.reverse()), this is dicom loading.
When loading dicom and segmentation, the segmentation is correct.

async function fetchDicom() {
    imageIds = await createImageIdsAndCacheMetaData(exConfig.fetchDicom);
    await loadDicom(imageIds.reverse());
}

image

But why?

@l5769389
Copy link

bug like the link #1170 (comment)

@l5769389
Copy link

@jlopes90, i find reverse the imageIds can match as you said。 bug will cause the segmentation and volume mismatch in volume render。as the figure after i reverse the imageIds。 left mpr 3 viewers works,but right error。
图片

@sedghi sedghi merged commit 33d39a0 into cornerstonejs:main May 15, 2024
9 checks passed
@jlopes90 jlopes90 deleted the docs-example-segmentation-volume branch June 25, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants