-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(CrosshairsTool): support HPDI screens in CrosshairsTool #1824
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
5e1c053
to
729d21f
Compare
@sedghi can you take a look at this fix ? |
Thanks for the PR! I see the visuals have changed quite a bit, and I'm not sure if we want to push that onto all users. Is there a way to implement your PR without such a significant visual change? Or, could we perhaps reduce the size of those handles? They're really large on my screen right now. |
Can you share a screenshot ? because i didn't changed the styles, only the size of the handles multiplied by window.devicePixelRatio. |
The screenshot is the same as the one above. What I mean is that there seems to be a big visual difference. Maybe the |
what do you think about |
I was kind of thinking along these lines:
same for the other one |
fix #1822
Context
Support HDPI screens in CrosshairsTool
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
My code has been well-documented (function documentation, inline comments,
etc.)
[] I have run the
yarn build:update-api
to update the API documentation, and havecommitted the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)
Public Documentation Updates
additions or removals.
Tested Environment