Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix meshes not centering when created using buffers #758

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

depilz
Copy link
Contributor

@depilz depilz commented Jan 16, 2025

Fixes this:

CleanShot.2025-01-16.at.18.01.58.mp4

Result:

CleanShot.2025-01-16.at.18.02.16.mp4

@ggcrunchy does this looks good to you?

@depilz depilz requested a review from Shchvova as a code owner January 16, 2025 22:16
@ggcrunchy
Copy link
Contributor

Definitely looks better in your example. 😄

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


depilz seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Shchvova
Copy link
Contributor

Reason I haven't merged it yet is because of backward compatibility. Do you think it'll break existing apps?

@ggcrunchy
Copy link
Contributor

@Shchvova Yeah, maybe the // center mesh block wants to be in a if (fromVertices) condition. Even if nothing did break, it would avoid redoing the calculation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants