Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more generator expressions in output directories #515

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Support more generator expressions in output directories #515

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 31 additions & 2 deletions cmake/Corrosion.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,35 @@ function(_corrosion_bin_target_suffix target_name out_var_suffix)
set(${out_var_suffix} "${_suffix}" PARENT_SCOPE)
endfunction()

function(_corrosion_genex_expand config_type genex_out genex)
string(GENEX_STRIP "${genex}" stripped)
while(NOT "${genex}" STREQUAL stripped)
set(genex_last "${genex}")

# NOTE: in all of the following example comments, config_type was Debug.
# $<CONFIG> -> Debug
string(REPLACE "\$<CONFIG>" "${config_type}" genex "${genex}")
# $<CONFIG:Debug> -> 1
string(REPLACE "\$<CONFIG:${config_type}>" "1" genex "${genex}")
# $<CONFIG:Release> -> 0
string(REGEX REPLACE "\\\$<CONFIG:[^>]*>" "0" genex "${genex}")
# $<1:true-string> -> true-string
string(REGEX REPLACE "\\\$<1:([^>]*)>" "\\1" genex "${genex}")
# $<0:true-string> ->
string(REGEX REPLACE "\\\$<0:([^>]*)>" "" genex "${genex}")
# $<IF:1,true-string,false-string> -> true-string
string(REGEX REPLACE "\\\$<IF:1,([^>,]*),([^>]*)>" "\\1" genex "${genex}")
Copy link
Collaborator

@jschwe jschwe May 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we could use the cmake raw strings feature, so that you don't need all these escapes: https://cmake.org/cmake/help/latest/manual/cmake-language.7.html#bracket-argument

# $<IF:0,true-string,false-string> -> false-string
string(REGEX REPLACE "\\\$<IF:0,([^>,]*),([^>]*)>" "\\2" genex "${genex}")

# no forward progress? stop trying.
if("${genex_last}" STREQUAL "${genex}")
break()
endif()
endwhile()
set("${genex_out}" "${genex}" PARENT_SCOPE)
endfunction()

# Do not call this function directly!
#
# This function should be called deferred to evaluate target properties late in the configure stage.
Expand Down Expand Up @@ -127,7 +156,7 @@ function(_corrosion_set_imported_location_deferred target_name base_property out
else()
set(curr_out_dir "${CMAKE_CURRENT_BINARY_DIR}")
endif()
string(REPLACE "\$<CONFIG>" "${config_type}" curr_out_dir "${curr_out_dir}")
_corrosion_genex_expand("${config_type}" curr_out_dir "${curr_out_dir}")
message(DEBUG "Setting ${base_property}_${config_type_upper} for target ${target_name}"
" to `${curr_out_dir}/${filename}`.")

Expand All @@ -153,7 +182,7 @@ function(_corrosion_set_imported_location_deferred target_name base_property out
else()
set(base_output_directory "${CMAKE_CURRENT_BINARY_DIR}")
endif()
string(REPLACE "\$<CONFIG>" "${CMAKE_BUILD_TYPE}" base_output_directory "${base_output_directory}")
_corrosion_genex_expand("${CMAKE_BUILD_TYPE}" base_output_directory "${base_output_directory}")
string(GENEX_STRIP "${base_output_directory}" stripped_out_dir)
if(NOT ("${stripped_out_dir}" STREQUAL "${base_output_directory}"))
message(FATAL_ERROR "${output_dir_prop_target_name} for target ${output_dir_prop_target_name} "
Expand Down