refactor: Players #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cory2067
requested changes
Mar 15, 2022
|
I also alpha sorted the players available for teams addition, and make the Select Option available both when Adding & Editing Teams |
cory2067
requested changes
Mar 28, 2022
cory2067
requested changes
Apr 2, 2022
| ); | ||
| setRefreshPercent(Math.min(100, Math.round((100 * offset) / players.length))); | ||
| setPlayers(sortedPlayers(sort, players)); |
There was a problem hiding this comment.
doing these two setPlayers calls back to back will run into the same async issue as before where it might not use the updated players
combine the two setPlayers calls, for example:
setPlayers(
sortedPlayers(sort,
players.map((p) => {
const newPlayer = result.players.filter((r) => r._id === p._id)[0];
return newPlayer || p;
})
)
);| {mode === "teams" && isAdmin() && ( | ||
| <Collapse> | ||
| <Panel header={`Add new team`} key="1"> | ||
| Type all player names separated by commas, with the captain's name first. |
There was a problem hiding this comment.
now that you don't need to type commas anymore, you could change the text to something like this
Add all player names, with the captain's name first
| tourney: tourney, | ||
| }); | ||
|
|
||
| setTeams((t) => { |
There was a problem hiding this comment.
this isn't quite right -- i noticed that it fails to update the teams
it should be like this:
setTeams(teams.map((t) => {
cory2067
approved these changes
Apr 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding #37 to refactor current state of the site, to migrate from Class Component based to use React Hooks
Known Issues currently:
message.errorlike usual.Files Changed:
Additional notes: