Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Py3 #18

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Py3 #18

wants to merge 16 commits into from

Conversation

PonteIneptique
Copy link

@PonteIneptique PonteIneptique commented Sep 11, 2018

So, I think I fixed #5 ...

@PonteIneptique
Copy link
Author

Let me know if this feel alright to you, so that I can clean a little...

@PonteIneptique
Copy link
Author

I would heavily recommend that this whole branch be squashed for a nicer history.
I did not know where to put my name, so I did not put it anywhere... :)

@funkyfuture
Copy link

i'm a little confused about the imports from builtins. is that some layer provided by six?

@PonteIneptique
Copy link
Author

It comes from all the compatibility modules from future. Future brings future, past and some of builtins for python 2 I think.

@PonteIneptique
Copy link
Author

I actually started to move type(x) to isinstance but I figured you might not want it. Tell me and I'll revert the last two.
As for the failure, it seems that there is sometime an issue with pytext upgrade because it works on my repo : https://travis-ci.org/PonteIneptique/surfrdf/jobs/427468789

@PonteIneptique
Copy link
Author

Hey, bumping this in case you can do something about it :)

@PonteIneptique
Copy link
Author

Just my usual bump, in case this was forgotten :) 👍

@maranqz
Copy link

maranqz commented Apr 21, 2020

@cosminbasca
Hello. Just notice about intersting pull request.

changing type checking (see issue #1) as per Thibault's suggestion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3 compatibility
4 participants