feat(store/v1): async pruning iavl #20321
Conversation
WalkthroughWalkthroughThe updates primarily involve advancing dependencies, notably upgrading Changes
Sequence DiagramsCommit and Pruning ProcesssequenceDiagram
participant Client
participant MultiStore
participant IAVLStore
Client->>MultiStore: SetCommitting(true)
MultiStore->>IAVLStore: SetCommitting(true)
Client-->>MultiStore: PausePruning(true)
MultiStore-->>IAVLStore: PausePruning(true)
Note over IAVLStore: Begin Commit
IAVLStore-->>MultiStore: Notify Commit Start
Client->>MultiStore: Commit
MultiStore->>IAVLStore: Commit
Note over IAVLStore: Perform Async Pruning
MultiStore-->>Client: Commit Done
MultiStore-->>IAVLStore: PausePruning(false)
Client-->>MultiStore: PausePruning(false)
Existing vs New Flow (High-Level)sequenceDiagram
participant Client
participant MultiStore
participant IAVLStore
Note over Client, MultiStore: Existing Flow
Client->>MultiStore: Commit
MultiStore->>IAVLStore: Commit
Note over Client, MultiStore: New Flow
Client->>MultiStore: SetCommitting(true)
MultiStore->>IAVLStore: SetCommitting(true)
Client-->>MultiStore: PausePruning(true)
MultiStore-->>IAVLStore: PausePruning(true)
Note over IAVLStore: Begin Commit
IAVLStore-->>MultiStore: Notify Commit Start
Client->>MultiStore: Commit
MultiStore->>IAVLStore: Commit
Note over IAVLStore: Perform Async Pruning
MultiStore-->>Client: Commit Done
MultiStore-->>IAVLStore: PausePruning(false)
Client-->>MultiStore: PausePruning(false)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
@cool-develope your pull request is missing a changelog! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files ignored due to path filters (2)
store/go.modis excluded by!**/*.modstore/go.sumis excluded by!**/*.sum
Files selected for processing (8)
- store/iavl/store.go (2 hunks)
- store/iavl/tree.go (2 hunks)
- store/mem/store.go (1 hunks)
- store/rootmulti/dbadapter.go (1 hunks)
- store/rootmulti/store.go (2 hunks)
- store/rootmulti/store_test.go (4 hunks)
- store/transient/store.go (1 hunks)
- store/types/store.go (1 hunks)
Files skipped from review due to trivial changes (1)
- store/rootmulti/store_test.go
Additional Context Used
Path-based Instructions (7)
store/transient/store.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.store/rootmulti/dbadapter.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.store/mem/store.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.store/iavl/tree.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.store/iavl/store.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.store/types/store.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.store/rootmulti/store.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Additional comments not posted (9)
store/transient/store.go (1)
34-34: The implementation ofSetCommittingas a no-op is appropriate for a transient store, where data does not persist beyond a session.store/rootmulti/dbadapter.go (1)
43-43: The implementation ofSetCommittingas a no-op is appropriate forcommitDBStoreAdapter, aligning with its characteristics of not computing any commit hash and not loading older state.store/mem/store.go (1)
53-53: The implementation ofSetCommittingas a no-op is appropriate for a memory store, where pruning operations are not required.store/iavl/tree.go (2)
59-59: The implementation ofSetCommittingto raise an exception on an immutable IAVL tree is appropriate, ensuring the tree's integrity by preventing state changes.
63-63: The implementation ofUnsetCommittingto raise an exception on an immutable IAVL tree is appropriate, ensuring the tree's integrity by preventing state changes.store/iavl/store.go (2)
55-55: The update toLoadStoreWithInitialVersionto includeiavl.AsyncPruningOption(true)is correctly implemented, aligning with the PR's objectives to enhance pruning efficiency by enabling asynchronous operations.
153-153: The implementation ofSetCommittingto delegate state changes based on theisCommitflag is appropriate, allowing the IAVL store to manage its committing status effectively.store/types/store.go (1)
30-30: The addition ofSetCommittingto theCommitterinterface is appropriate, enabling different store types to implement their own pruning logic during commit phases, aligning with the PR's objectives.store/rootmulti/store.go (1)
461-466: Ensure that all stores implementSetCommittingmethod to avoid runtime panics.Verification successful
The verification process has confirmed that all store types within the codebase implement the
SetCommittingmethod. This includes theStoretypes instore/rootmulti,store/mem,store/iavl, andstore/transient. Therefore, the concern about potential runtime panics due to missing implementations of this method is unfounded.
store/rootmulti/store.go:SetCommittingimplementedstore/mem/store.go:SetCommittingimplementedstore/iavl/store.go:SetCommittingimplementedstore/transient/store.go:SetCommittingimplementedScripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that all stores implement the `SetCommitting` method. # Test: Search for stores that might not implement `SetCommitting`. Expect: No results. rg --type go $'func \\\\(.*Store\\\\) SetCommitting\\\\('Length of output: 173
Script:
#!/bin/bash # Description: Verify that all stores implement the `SetCommitting` method. # Test: Search for stores that might not implement `SetCommitting`. Expect: No results. rg --type go 'func \(.*Store\) SetCommitting\('Length of output: 319
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| SetCommitting() | ||
| UnsetCommitting() | ||
| SaveVersion() ([]byte, int64, error) |
There was a problem hiding this comment.
do we need to break this interface?
There was a problem hiding this comment.
yes, this is the interface of MutableTree, not allow to modify it
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files ignored due to path filters (6)
simapp/go.modis excluded by!**/*.modsimapp/go.sumis excluded by!**/*.sumstore/go.modis excluded by!**/*.modstore/go.sumis excluded by!**/*.sumtests/go.modis excluded by!**/*.modtests/go.sumis excluded by!**/*.sum
Files selected for processing (3)
- simapp/gomod2nix.toml (7 hunks)
- store/rootmulti/store.go (2 hunks)
- store/types/store.go (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- store/rootmulti/store.go
- store/types/store.go
Additional comments not posted (10)
simapp/gomod2nix.toml (10)
5-6: Ensure the updated version and hash forbuf.build/gen/go/cometbft/cometbft/protocolbuffers/goare correct and consistent with the source.
8-9: Ensure the updated version and hash forbuf.build/gen/go/cosmos/gogo-proto/protocolbuffers/goare correct and consistent with the source.
135-136: Ensure the updated version and hash forgithub.com/cosmos/iavlare correct and consistent with the source.
276-277: Ensure the updated version and hash forgithub.com/hashicorp/go-hclogare correct and consistent with the source.
390-391: Ensure the updated version and hash forgithub.com/pelletier/go-toml/v2are correct and consistent with the source.
402-403: Ensure the updated version and hash forgithub.com/prometheus/client_golangare correct and consistent with the source.
514-515: Ensure the updated version and hash forgolang.org/x/cryptoare correct and consistent with the source.
517-518: Ensure the updated version and hash forgolang.org/x/expare correct and consistent with the source.
523-524: Ensure the updated version and hash forgolang.org/x/netare correct and consistent with the source.
532-533: Ensure the updated version and hash forgolang.org/x/sysare correct and consistent with the source.
|
@tac0turtle , need new tag? |
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (3)
- store/iavl/store.go (2 hunks)
- store/rootmulti/store.go (5 hunks)
- store/types/store.go (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- store/rootmulti/store.go
Additional Context Used
Path-based Instructions (2)
store/iavl/store.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.store/types/store.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Additional comments not posted (3)
store/iavl/store.go (2)
55-55: Async pruning option added.
150-157: PausePruning method added.store/types/store.go (1)
32-36: The newPausablePrunerinterface looks good and is well-documented.
|
@kocubinski appreciate update 🙏 |
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files ignored due to path filters (6)
simapp/go.modis excluded by!**/*.modsimapp/go.sumis excluded by!**/*.sumstore/go.modis excluded by!**/*.modstore/go.sumis excluded by!**/*.sumtests/go.modis excluded by!**/*.modtests/go.sumis excluded by!**/*.sum
Files selected for processing (1)
- simapp/gomod2nix.toml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- simapp/gomod2nix.toml
| if pause { | ||
| st.tree.SetCommitting() | ||
| } else { | ||
| st.tree.UnsetCommitting() |
There was a problem hiding this comment.
I looked into the iavl impl and this method is not safe to be called (multiple times) without a SetCommitting before. This is risky for a public method as people may use it without deeper knowledge. PausePruning(false) does not look like a 💣
IMHO it makes sense to fix UnsetCommitting.
There was a problem hiding this comment.
I was also thinking if we need to provide better locking so that no other process accidentally unlocks? Do you think such a scenario exists? In this case, control must be within the iavl and you can have a tree.DoWithCommitPaused{func(){...}) that is guarded
There was a problem hiding this comment.
I believe those should be handled within iavl, cosmos/iavl#953
I added some comments for this PR.
store/rootmulti/store_test.go
Outdated
| // Ensure async pruning is done | ||
| time.Sleep(500 * time.Millisecond) | ||
| ms.Commit() | ||
|
|
There was a problem hiding this comment.
Tests are passing without PausePruning set. How can you ensure the expected behaviour?
There was a problem hiding this comment.
PausePruning is handled within Commit, the extra commit is for batch flushing.
There was a problem hiding this comment.
It is not straight forward but you can ensure the pauses calls with some decorator:
var _ types.PausablePruner = &pauseableCommitKVStoreStub{}
type pauseableCommitKVStoreStub struct {
types.CommitKVStore
pauseCalled []bool
}
func (p *pauseableCommitKVStoreStub) PausePruning(b bool) {
p.pauseCalled = append(p.pauseCalled, b)
}
func TestPausePruningOnCommit(t *testing.T) {
store := NewStore(dbm.NewMemDB(), log.NewNopLogger(), metrics.NewNoOpMetrics())
store.SetPruning(pruningtypes.NewCustomPruningOptions(2, 11))
store.MountStoreWithDB(testStoreKey1, types.StoreTypeIAVL, nil)
require.NoError(t, store.LoadLatestVersion())
myStub := &pauseableCommitKVStoreStub{CommitKVStore: store.stores[testStoreKey1]}
store.stores[testStoreKey1] = myStub
// when
store.Commit()
// then
assert.Equal(t, []bool{true, false}, myStub.pauseCalled)
}
There was a problem hiding this comment.
Actionable comments posted: 4
Review Details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (3)
- store/rootmulti/store.go (5 hunks)
- store/rootmulti/store_test.go (4 hunks)
- store/types/store.go (1 hunks)
Additional Context Used
Path-based Instructions (3)
store/types/store.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.store/rootmulti/store_test.go (2)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Pattern
**/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"store/rootmulti/store.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Additional comments not posted (2)
store/types/store.go (1)
32-38: The addition of thePausablePrunerinterface is well-implemented and clearly documented.store/rootmulti/store_test.go (1)
583-596: The test case for pruning the same heights twice is correctly implemented to ensure idempotency and stability of the pruning process.
store/rootmulti/store_test.go
Outdated
| @@ -617,6 +624,10 @@ func TestMultiStore_PruningRestart(t *testing.T) { | |||
| actualHeightToPrune = ms.pruningManager.GetPruningHeight(ms.LatestVersion()) | |||
| require.Equal(t, int64(8), actualHeightToPrune) | |||
|
|
|||
| // Ensure async pruning is done | |||
| time.Sleep(500 * time.Millisecond) | |||
| ms.Commit() | |||
There was a problem hiding this comment.
nit: do you need this extra commit? It is passing without
There was a problem hiding this comment.
yes, to flush the batch data which includes pruning info
store/rootmulti/store_test.go
Outdated
| // Ensure async pruning is done | ||
| time.Sleep(500 * time.Millisecond) | ||
| ms.Commit() | ||
|
|
There was a problem hiding this comment.
It is not straight forward but you can ensure the pauses calls with some decorator:
var _ types.PausablePruner = &pauseableCommitKVStoreStub{}
type pauseableCommitKVStoreStub struct {
types.CommitKVStore
pauseCalled []bool
}
func (p *pauseableCommitKVStoreStub) PausePruning(b bool) {
p.pauseCalled = append(p.pauseCalled, b)
}
func TestPausePruningOnCommit(t *testing.T) {
store := NewStore(dbm.NewMemDB(), log.NewNopLogger(), metrics.NewNoOpMetrics())
store.SetPruning(pruningtypes.NewCustomPruningOptions(2, 11))
store.MountStoreWithDB(testStoreKey1, types.StoreTypeIAVL, nil)
require.NoError(t, store.LoadLatestVersion())
myStub := &pauseableCommitKVStoreStub{CommitKVStore: store.stores[testStoreKey1]}
store.stores[testStoreKey1] = myStub
// when
store.Commit()
// then
assert.Equal(t, []bool{true, false}, myStub.pauseCalled)
}
There was a problem hiding this comment.
Actionable comments posted: 1
Review Details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (3)
- store/iavl/store.go (3 hunks)
- store/rootmulti/store.go (5 hunks)
- store/rootmulti/store_test.go (4 hunks)
Files skipped from review as they are similar to previous changes (2)
- store/rootmulti/store.go
- store/rootmulti/store_test.go
Additional Context Used
Path-based Instructions (1)
store/iavl/store.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Additional comments not posted (2)
store/iavl/store.go (2)
34-34: Interface implementation confirmed.The
Storestruct is correctly asserted to implement thetypes.PausablePrunerinterface, ensuring type safety.
151-158: Review the implementation ofPausePruning.This method toggles the committing state of the tree, which is crucial for the new asynchronous pruning feature. Ensure that the locking mechanism is robust enough to handle concurrent accesses as suggested in previous comments.
| @@ -52,7 +53,7 @@ func LoadStore(db dbm.DB, logger log.Logger, key types.StoreKey, id types.Commit | |||
| // provided DB. An error is returned if the version fails to load, or if called with a positive | |||
| // version on an empty tree. | |||
| func LoadStoreWithInitialVersion(db dbm.DB, logger log.Logger, key types.StoreKey, id types.CommitID, initialVersion uint64, cacheSize int, disableFastNode bool, metrics metrics.StoreMetrics) (types.CommitKVStore, error) { | |||
| tree := iavl.NewMutableTree(wrapper.NewDBWrapper(db), cacheSize, disableFastNode, logger, iavl.InitialVersionOption(initialVersion)) | |||
| tree := iavl.NewMutableTree(wrapper.NewDBWrapper(db), cacheSize, disableFastNode, logger, iavl.InitialVersionOption(initialVersion), iavl.AsyncPruningOption(true)) | |||
There was a problem hiding this comment.
Tip
Codebase Verification
Ensure consistent handling of the new pruning options.
The new pruning option iavl.AsyncPruningOption is only applied in one instance of iavl.NewMutableTree in store/iavl/store.go. Other instances of iavl.NewMutableTree do not include this option, which may lead to inconsistent behavior.
store/v2/commitment/iavl/tree.gostore/prefix/store_test.gostore/iavl/store_test.gostore/cache/cache_test.go
Please review these instances to ensure the new pruning option is correctly and consistently applied.
Analysis chain
Ensure proper handling of new pruning options.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify that the new pruning options are correctly handled throughout the system.
# Test: Search for usage of `iavl.AsyncPruningOption` to ensure it's correctly implemented.
rg --type go $'iavl.AsyncPruningOption'
Length of output: 223
Script:
#!/bin/bash
# Description: Verify that the new pruning options are correctly handled throughout the system.
# Test: Search for all instances of `iavl.NewMutableTree` to ensure the new pruning option is consistently applied.
rg --type go 'iavl.NewMutableTree'
Length of output: 2000
github-actions
bot
added
C:x/staking
C:CLI
C:x/gov
C:x/slashing
C:x/distribution
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files ignored due to path filters (5)
client/v2/go.sumis excluded by!**/*.sumgo.sumis excluded by!**/*.sumsimapp/go.sumis excluded by!**/*.sumstore/go.sumis excluded by!**/*.sumtests/go.sumis excluded by!**/*.sum
Files selected for processing (6)
- client/v2/go.mod (1 hunks)
- go.mod (1 hunks)
- simapp/go.mod (1 hunks)
- simapp/gomod2nix.toml (11 hunks)
- store/go.mod (1 hunks)
- tests/go.mod (1 hunks)
Files skipped from review due to trivial changes (4)
- client/v2/go.mod
- go.mod
- store/go.mod
- tests/go.mod
Additional comments not posted (4)
simapp/go.mod (1)
90-90: Update togithub.com/cosmos/iavl v1.2.0aligns with the PR's goal to enhance the IAVL pruning logic.This update is crucial for the new asynchronous pruning features introduced in the store module, ensuring compatibility with the latest IAVL methods.
simapp/gomod2nix.toml (3)
291-292: Updatedgithub.com/hashicorp/golang-lru/v2tov2.0.7. Ensure this update does not introduce any breaking changes or performance regressions.Verification successful
The verification scripts executed did not find any mentions of breaking changes in the release notes for any of the recent versions of
github.com/hashicorp/golang-lru/v2. Additionally, no issues or discussions mentioning breaking changes were found in the repository. The usage ofgithub.com/hashicorp/golang-lru/v2in the codebase is indirect, as indicated by thego.modandgo.sumfiles.Given this information, it appears that the update to
v2.0.7ofgithub.com/hashicorp/golang-lru/v2does not introduce any breaking changes or performance regressions.
- No breaking changes were found in the release notes for versions
v2.0.0tov2.0.6.- No issues or discussions related to breaking changes were found in the repository.
- The dependency is used indirectly in the codebase.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify no breaking changes in hashicorp golang-lru v2.0.7. # Test: Search for breaking changes mentioned in the release notes. curl -s https://github.com/hashicorp/golang-lru/releases/tag/v2.0.7 | grep "breaking changes"Length of output: 95
Script:
#!/bin/bash # Description: Verify no breaking changes in recent versions of hashicorp golang-lru. # Define the versions to check. versions=("v2.0.6" "v2.0.5" "v2.0.4" "v2.0.3" "v2.0.2" "v2.0.1" "v2.0.0") # Loop through each version and check for breaking changes in the release notes. for version in "${versions[@]}"; do echo "Checking release notes for version $version..." curl -s "https://github.com/hashicorp/golang-lru/releases/tag/$version" | grep -i "breaking changes" doneLength of output: 1699
Script:
#!/bin/bash # Description: Search for issues or discussions mentioning breaking changes in the hashicorp golang-lru repository. # Search for issues mentioning breaking changes. curl -s "https://api.github.com/repos/hashicorp/golang-lru/issues?state=all" | jq '.[] | select(.title | test("breaking changes"; "i")) | {title, html_url}' # Search for discussions mentioning breaking changes. curl -s "https://api.github.com/repos/hashicorp/golang-lru/discussions?state=all" | jq '.[] | select(.title | test("breaking changes"; "i")) | {title, html_url}'Length of output: 388
Script:
#!/bin/bash # Description: Ensure compatibility with the rest of the codebase by checking for direct usage of hashicorp golang-lru. # Search for import statements of hashicorp golang-lru in the codebase. rg 'github.com/hashicorp/golang-lru/v2'Length of output: 7348
553-554: Updatedgoogle.golang.org/protobuftov1.34.2. Verify compatibility with other protobuf-related dependencies and ensure there are no deprecation issues.Verification successful
Let's gather the versions of the protobuf-related dependencies and check for any compatibility issues or deprecations.
To ensure compatibility and check for any deprecations or breaking changes, I need to verify the release notes and breaking changes for the protobuf-related dependencies. This will confirm if the updated version of
google.golang.org/protobuftov1.34.2is compatible with the other protobuf dependencies.
The release notes for the protobuf-related dependencies indicate that there are no breaking changes or significant compatibility issues with the updated version of
google.golang.org/protobuftov1.34.2. The updates include minor features and bug fixes, which are unlikely to affect the existing functionalities.
google.golang.org/protobufv1.34.2: Minor feature and bug fixes.github.com/golang/protobufv1.5.4: Updated descriptor.proto to the latest version.github.com/gogo/protobufv1.3.2: Bug fixes and tested versions.Based on this information, the update appears to be safe and compatible with the other protobuf-related dependencies.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check compatibility of updated protobuf version with other protobuf-related dependencies. # Test: List all protobuf-related dependencies and their versions. grep "protobuf" simapp/gomod2nix.tomlLength of output: 146
Script:
#!/bin/bash # Description: List versions of all protobuf-related dependencies. # Test: Get version information for protobuf-related dependencies. grep -A 2 "github.com/gogo/protobuf" simapp/gomod2nix.toml grep -A 2 "github.com/golang/protobuf" simapp/gomod2nix.toml grep -A 2 "google.golang.org/protobuf" simapp/gomod2nix.tomlLength of output: 554
Script:
#!/bin/bash # Description: Check release notes for breaking changes and compatibility issues for protobuf-related dependencies. # Fetch release notes for google.golang.org/protobuf v1.34.2 curl -s https://api.github.com/repos/protocolbuffers/protobuf-go/releases/tags/v1.34.2 | jq '.body' # Fetch release notes for github.com/golang/protobuf v1.5.4 curl -s https://api.github.com/repos/golang/protobuf/releases/tags/v1.5.4 | jq '.body' # Fetch release notes for github.com/gogo/protobuf v1.3.2 curl -s https://api.github.com/repos/gogo/protobuf/releases/tags/v1.3.2 | jq '.body'Length of output: 1091
129-130: Updatedgithub.com/cosmos/iavltov1.2.0. Confirm this version supports the new asynchronous pruning features as described in the PR.Verification successful
The updated version
v1.2.0ofgithub.com/cosmos/iavlincludes the methodsPausePruningandSetCommitting, which support asynchronous pruning features.
store/iavl/tree.gostore/iavl/store.gostore/v2/commitment/iavl/tree.goScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for asynchronous pruning support in IAVL v1.2.0. # Test: Search for relevant methods in the IAVL repository. rg --type go "PausePruning|SetCommitting" -- /path/to/local/iavl/repoLength of output: 136
Script:
#!/bin/bash # Locate the `github.com/cosmos/iavl` repository directory within the project. fd -t d 'iavl'Length of output: 52
Script:
#!/bin/bash # Check for asynchronous pruning support in the identified directories. # Search `store/iavl/` for relevant methods. rg --type go "PausePruning|SetCommitting" store/iavl/ # Search `store/v2/commitment/iavl/` for relevant methods. rg --type go "PausePruning|SetCommitting" store/v2/commitment/iavl/Length of output: 703
Description
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Summary by CodeRabbit
New Features
Bug Fixes
Chores
github.com/cosmos/iavlto versionv1.2.0.