imp: decouple abi files #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #248 +/- ##
==========================================
+ Coverage 99.29% 99.47% +0.18%
==========================================
Files 12 12
Lines 566 572 +6
==========================================
+ Hits 562 569 +7
+ Misses 4 3 -1 ☔ View full report in Codecov by Sentry. |
srdtrk
commented
Jan 30, 2025
Comment on lines
-502
to
-529
|
|
||
| /// @notice A dummy function to generate the ABI for the parameters. | ||
| /// @param o1 The MembershipOutput. | ||
| /// @param o2 The UcAndMembershipOutput. | ||
| /// @param o3 The MsgUpdateClient. | ||
| /// @param o4 The MembershipProof. | ||
| /// @param o5 The SP1MembershipProof. | ||
| /// @param o6 The SP1MembershipAndUpdateClientProof. | ||
| /// @param o7 The MisbehaviourOutput. | ||
| /// @param o8 The MsgSubmitMisbehaviour. | ||
| function abiPublicTypes( | ||
| MembershipOutput memory o1, | ||
| UcAndMembershipOutput memory o2, | ||
| MsgUpdateClient memory o3, | ||
| MembershipProof memory o4, | ||
| SP1MembershipProof memory o5, | ||
| SP1MembershipAndUpdateClientProof memory o6, | ||
| MisbehaviourOutput memory o7, | ||
| MsgSubmitMisbehaviour memory o8 | ||
| ) | ||
| public | ||
| pure | ||
| // solhint-disable-next-line no-empty-blocks | ||
| { | ||
| // This is a dummy function to generate the ABI for outputs | ||
| // so that it can be used in the SP1 verifier contract. | ||
| // The function is not used in the contract. | ||
| } |
There was a problem hiding this comment.
This is the motivation for the PR
There was a problem hiding this comment.
Nice, love getting rid of this ❤️
gjermundgaraba
approved these changes
Jan 30, 2025
|
This is really great work! The repo is getting cleaner and cleaner ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes the need to expose structs in solidity through a dummy function. Moreover, it cleans up the rust code. It makes it much easier to decouple if we never inherit the message interfaces like I did in this PR.
closes: #131
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.