imp: consistent encoding of sp1 inputs #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #252 +/- ##
=======================================
Coverage 99.47% 99.47%
=======================================
Files 12 12
Lines 572 572
=======================================
Hits 569 569
Misses 3 3 ☔ View full report in Codecov by Sentry. |
srdtrk
commented
Feb 2, 2025
| bincode = { workspace = true } | ||
| serde_cbor = { workspace = true, features = ["std"] } | ||
| prost = { workspace = true } |
There was a problem hiding this comment.
I decided that we either use protobuf encoding (convenient for ibc types) or ethereum abi encoding (convenient for contracts). There is no "clean" way to use just one of these in my opinion. And this keeps the code clean as well
Comment on lines
+23
to
+25
| // Re-export the supported zk algorithms. | ||
| pub use ibc_eureka_solidity_types::msgs::IICS07TendermintMsgs::SupportedZkAlgorithm; | ||
|
|
There was a problem hiding this comment.
I moved this to a separate line. (No new logic here)
gjermundgaraba
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #132
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.