Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added universal error ack #259

Merged
merged 19 commits into from
Feb 6, 2025
Merged

Conversation

srdtrk
Copy link
Member

@srdtrk srdtrk commented Feb 6, 2025

Description

closes: #112
closes: #256


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Wrote unit and integration tests.
  • Added relevant natspec and godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@srdtrk srdtrk changed the title feat: added universal error acks feat: added universal error ack Feb 6, 2025
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.82%. Comparing base (ae036e2) to head (34acd0a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
- Coverage   99.82%   99.82%   -0.01%     
==========================================
  Files          13       13              
  Lines         568      567       -1     
==========================================
- Hits          567      566       -1     
  Misses          1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@srdtrk srdtrk marked this pull request as ready for review February 6, 2025 20:46
Copy link
Contributor

@gjermundgaraba gjermundgaraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! The code looks even better now 🚀

@gjermundgaraba gjermundgaraba merged commit 8d6614b into main Feb 6, 2025
61 checks passed
@gjermundgaraba gjermundgaraba deleted the serdar/112-callback-errors branch February 6, 2025 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Universal error ack Catch errors in App callbacks
2 participants