Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added misbehavior to ethereum light client #270

Merged
merged 4 commits into from
Feb 10, 2025

Conversation

srdtrk
Copy link
Member

@srdtrk srdtrk commented Feb 10, 2025

Description

closes: #164


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Wrote unit and integration tests.
  • Added relevant natspec and godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@srdtrk srdtrk changed the title feat: include ethereum misbehavior feat: added misbehavior to ethereum light client Feb 10, 2025
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.83%. Comparing base (506eee9) to head (3439465).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #270   +/-   ##
=======================================
  Coverage   99.83%   99.83%           
=======================================
  Files          13       13           
  Lines         600      600           
=======================================
  Hits          599      599           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@srdtrk srdtrk marked this pull request as ready for review February 10, 2025 16:58
Copy link
Contributor

@gjermundgaraba gjermundgaraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very clean and easy to understand! Love it!
Added unit and e2e testing of this to #144

@gjermundgaraba gjermundgaraba merged commit 13ee7cc into main Feb 10, 2025
61 checks passed
@gjermundgaraba gjermundgaraba deleted the serdar/164-eth-misbehavior-2 branch February 10, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add misbehavior to ethereum light client
2 participants