feat: added rate limiting to Escrow #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #274 +/- ##
=======================================
Coverage 99.83% 99.84%
=======================================
Files 13 14 +1
Lines 621 650 +29
=======================================
+ Hits 620 649 +29
Misses 1 1 ☔ View full report in Codecov by Sentry. |
| /// @notice Checks the rate limit for a token and updates the daily usage | ||
| /// @param token The token address | ||
| /// @param amount The amount to check against the rate limit | ||
| function _checkRateLimit(address token, uint256 amount) internal { |
There was a problem hiding this comment.
This needs a better name, because it is not clear from the name that it also updates the daily usage. The check implies that it just checks it. Either something a bit more verbose like verifyAndUpdateDailyRate or if we want something shorter maybe applyRateLimit.
Comment on lines
62
to
64
| if (rateLimit != 0) { | ||
| require(usage <= rateLimit, RateLimitExceeded(rateLimit, usage)); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (rateLimit != 0) { | |
| require(usage <= rateLimit, RateLimitExceeded(rateLimit, usage)); | |
| } | |
| if (rateLimit == 0) { | |
| return | |
| } | |
| require(usage <= rateLimit, RateLimitExceeded(rateLimit, usage)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #271
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.