-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imp: single service for all relayer modules #279
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #279 +/- ##
=======================================
Coverage 99.84% 99.84%
=======================================
Files 14 14
Lines 643 643
=======================================
Hits 642 642
Misses 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it mostly looks really good. 🚀 Thank you for pulling through so quickly on this 🙏
The only thing I want to change (which I will look at shortly) is the module serve function which doesn't make much sense anymore.
config: serde_json::Value, | ||
addr: SocketAddr, | ||
) -> Result<(), tonic::transport::Error> { | ||
async fn serve(&self, config: serde_json::Value) -> anyhow::Result<Box<dyn RelayerService>> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a confusing artifact that doesn't really make sense anymore. I think a more reasonable approach might be simply let the modules not need to care about how the config gets to them, and instead just have the router that do this work and call new. I will look into this after I'm done with my current deployment work.
Description
closes: #224
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
godoc
comments.Files changed
in the GitHub PR explorer.SonarCloud Report
in the comment section below once CI passes.