Skip to content
This repository has been archived by the owner on Nov 29, 2024. It is now read-only.

refactor: added 'notFrozen' modifier and refactored reverts to use require #133

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

srdtrk
Copy link
Member

@srdtrk srdtrk commented Nov 14, 2024

closes: #101

Copy link
Contributor

@gjermundgaraba gjermundgaraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell, we don't have any code that actually tests the frozen state. Can you add a test that submits a misbehaviour or something and then verify that the all the calls will revert correctly?

@srdtrk srdtrk merged commit 2206bbf into main Nov 14, 2024
25 checks passed
@srdtrk srdtrk deleted the serdar/101-not-frozen branch November 14, 2024 13:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a not frozen modifier for SP1ICS07Tendermint
2 participants