Cherry pick 3.2.1-3.2.2 to master #3363
Open
+2,956
−651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
velicuvlad
commented
Feb 13, 2025
velicuvlad
commented
- New LogSink API
- New Partial Index API
- LiteCore 4.0.0-39
* CBL-6456 : Implement Swift LogSink API * Implemented Swift LogSink API. * Fixed using out-of-scope CBLStringBytes when setting directory and header to C4 API for CBLFileLogSink ; Added an option to CBLStringBytes to disable inline storage. * Ran the script to generate public symbol for the logging API. * Renamed domain property to domains in CBLConsoleLogSink and CBLCustomLogSink. * Changed maxKepthFiles to NSInteger and maxFileSize to long long in CBLFileLogSink. * Updated and completed missing API docs in Objective-C LogSink API. * Used @testable import so that the tests can use the internal function.
* Partial index impl and tests * LiteCore 3.2.2-8 * update testVectorMatchLimitBoundary
The class initialize method is + initialize instead of + init.
* Add missing headers in Swift Private Module Map files. * Fix build and deprecation error.
|
I believe Partial Index is only defined and not implemented in LiteCore for 4.0.0-39. Hence the tests failing... |
|
I think it's better to wait for a new LiteCore with partial index otherwise the PR validation will continue to be failed. |
bmeike
approved these changes
Feb 18, 2025
| } | ||
| } | ||
|
|
||
| - (CBLLogLevel) level { |
There was a problem hiding this comment.
Is this SOP? You need the lock on the set, but not on the get?
| @@ -2,7 +2,7 @@ | |||
| // CBLFullTextIndexConfiguration.h | |||
| // CouchbaseLite | |||
| // | |||
| // Copyright (c) 2024 Couchbase, Inc All rights reserved. | |||
| // Copyright (c) 2025 Couchbase, Inc All rights reserved. | |||
There was a problem hiding this comment.
I think that standard practice is to include them all: 2024, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.